Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pipelines): cross region S3 bucket - block public access #16411

Closed
2 tasks
0xjjoyy opened this issue Sep 8, 2021 · 2 comments · Fixed by #17722
Closed
2 tasks

(pipelines): cross region S3 bucket - block public access #16411

0xjjoyy opened this issue Sep 8, 2021 · 2 comments · Fixed by #17722
Labels
@aws-cdk/aws-s3 Related to Amazon S3 @aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@0xjjoyy
Copy link

0xjjoyy commented Sep 8, 2021

The cross region S3 bucket that is created should have block public access enabled by default.

Looking at the synthed template, the block public access is not enabled.

Use Case

Ensure s3 block public access protection at the bucket level.

Proposed Solution

Include for any cross region s3 buckets.

    "PublicAccessBlockConfiguration": {
      "BlockPublicAcls": true,
      "BlockPublicPolicy": true,
      "IgnorePublicAcls": true,
      "RestrictPublicBuckets": true
    }

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@0xjjoyy 0xjjoyy added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 8, 2021
@github-actions github-actions bot added @aws-cdk/aws-s3 Related to Amazon S3 @aws-cdk/pipelines CDK Pipelines library labels Sep 8, 2021
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Sep 17, 2021
@rix0rrr rix0rrr removed their assignment Sep 17, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 17, 2021

Sounds good! PR welcome!

@otaviomacedo otaviomacedo removed their assignment Sep 17, 2021
david-richer-adsk added a commit to david-richer-adsk/aws-cdk that referenced this issue Nov 25, 2021
@david-richer-adsk
feat(codepipeline): Cross region S3 buckets block public access by de…
54df648 
…fault.

The cross region S3 buckets that are created should have block public access by default.

fixes aws#16411
@david-richer-adsk david-richer-adsk mentioned this issue Nov 25, 2021
Merged
@mergify mergify bot closed this as completed in #17722 Dec 9, 2021
mergify bot pushed a commit that referenced this issue Dec 9, 2021
@david-richer-adsk
fix(codepipeline): default cross-region S3 buckets allow public access (
0b80db5 
#17722)

The cross region S3 buckets that are created should have block public access by default.

Fixes #16411

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@david-richer-adsk @TikiTDO
fix(codepipeline): default cross-region S3 buckets allow public access (
7dac317 
aws#17722)

The cross region S3 buckets that are created should have block public access by default.

Fixes aws#16411

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-s3 Related to Amazon S3 @aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(codepipeline): default cross-region S3 buckets allow public access david-richer-adsk/aws-cdk
3 participants
@otaviomacedo @rix0rrr @0xjjoyy