feat(sns): addSubscription returns the created Subscription #16785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow creating dependencies on the subscription by return it from addSubscription(). Before this change the subscription resource was hidden. Creating a dependency required manually creating the subscription resource.
|
|
peterwoodworth
changed the title
github-actions
bot
added
the
@aws-cdk/aws-sns
njlynch
changed the title
njlynch
added
the
pr-linter/exempt-readme
njlynch
previously approved these changes
Oct 25, 2021
njlynch
added
the
pr-linter/exempt-test
|
Sorry @njlynch seems like we were stepping on each other's toes here. I already started to work on a basic test to make CodeBuild happy. I'll ping you when it's ready. Right now I'm fighting with GitPod. I keep getting weird unrelated errors about CloudWatch when trying to run the test. |
|
GitPod wouldn't even start up for me anymore 🤷 @njlynch it's ready. The test is a bit simplistic, but it does convey why I created the PR in the first place. I can remove it if you think it doesn't add much value and we can stick with the exempt-tests label. |
njlynch
approved these changes
Oct 26, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2021
…ption (#16785)" (#17166) This reverts commit 62f389e. Changing the return type from void to Subscription is a breaking change for F# customers, where the return type changes from "unit" to "Subscription", potentially breaking `do` statements. Example: https://github.com/aws/aws-cdk/blob/62f389ea0522cbaefca5ca17080228031d401ce6/packages/aws-cdk/lib/init-templates/v1/sample-app/fsharp/src/%25name.PascalCased%25/%25name.PascalCased%25Stack.template.fs#L14 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
@njlynch I just see this get released with v2.0.0-rc.28. Does that mean it will be in v2.x but not in v1.x? |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Allow creating dependencies on the subscription by returning it from `addSubscription()`. Before this change the subscription resource was inaccessible. Creating a dependency required manually creating the subscription resource.
Our current workaround is:
```
topic = sns.Topic(self, "topic")
subscription_req = subs.SqsSubscription(queue)
subscription_data = subscription_req.bind(topic)
subscription = sns.Subscription(
self,
"Subscription",
topic=topic,
endpoint=subscription_data.endpoint,
protocol=subscription_data.protocol,
region=subscription_data.region,
raw_message_delivery=subscription_data.raw_message_delivery,
filter_policy=subscription_data.filter_policy,
dead_letter_queue=subscription_data.dead_letter_queue,
)
something.add_dependency(subscription)
```
And it would be much simpler as:
```
topic = sns.Topic(self, "topic")
subscription = topic.add_subscription(subs.SqsSubscription(queue))
something.add_dependency(subscription)
```
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ption (aws#16785)" (aws#17166) This reverts commit 62f389e. Changing the return type from void to Subscription is a breaking change for F# customers, where the return type changes from "unit" to "Subscription", potentially breaking `do` statements. Example: https://github.com/aws/aws-cdk/blob/62f389ea0522cbaefca5ca17080228031d401ce6/packages/aws-cdk/lib/init-templates/v1/sample-app/fsharp/src/%25name.PascalCased%25/%25name.PascalCased%25Stack.template.fs#L14 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow creating dependencies on the subscription by returning it from
addSubscription(). Before this change the subscription resource was inaccessible. Creating a dependency required manually creating the subscription resource.Our current workaround is:
And it would be much simpler as:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license