fix(core): asset hash is different between linux and windows #16945
Conversation
The hash for a specific file in a directory include its relative path. This gives different results on Linux vs Windows because of the different path separator. The solution is to normalize the relative path using forward slashes. Affects directory assets with subdirectories. Closes aws#14555 Closes aws#16928
|
|
|
(see also #16928 (comment) for explanation on why it affects the |
jogold
changed the title
| @@ -53,7 +53,8 @@ export function fingerprint(fileOrDirectory: string, options: FingerprintOptions | |||
| return hash.digest('hex'); | |||
|
|
|||
| function _processFileOrDirectory(symbolicPath: string, isRootDir: boolean = false, realPath = symbolicPath) { | |||
| const relativePath = path.relative(fileOrDirectory, symbolicPath); | |||
| // Normalize relative path with forward slashes to ensure same hash on Windows and Linux | |||
| const relativePath = path.relative(fileOrDirectory, symbolicPath).replace(/\\/g, '/'); | |||
There was a problem hiding this comment.
seems like this value is only used as a hash component and not passed into file system operations, correct?
If that is indeed the case, let's rename to hashComponent.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The hash for a specific file in a directory include its relative path. This gives different results on Linux vs Windows because of the different path separator. The solution is to normalize the relative path using forward slashes. Affects directory assets with subdirectories. Closes aws#14555 Closes aws#16928 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The hash for a specific file in a directory include its relative path.
This gives different results on Linux vs Windows because of the
different path separator. The solution is to normalize the relative path
using forward slashes.
Affects directory assets with subdirectories.
Closes #14555
Closes #16928
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license