Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): PhysicalName.GENERATE_IF_NEEDED does not work for EventBus #17008

Merged
merged 2 commits into from Oct 19, 2021

Conversation

corymhall
Copy link
Contributor

fixes an issue where the generate when needed marker was not being
passed through to the physicalName

fix #14337


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

environment consumption

fixes an issue where the generate when needed marker was not being
passed through to the physicalName

fix #14337
@gitpod-io
Copy link

gitpod-io bot commented Oct 15, 2021

@rix0rrr rix0rrr changed the title fix(aws-events): eventBusName can use generate if needed for cross environment consumption fix(events): PhysicalName.GENERATE_IF_NEEDED does not work for EventBus Oct 19, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ebac0d5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 707fa00 into aws:master Oct 19, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…us (aws#17008)

fixes an issue where the generate when needed marker was not being
passed through to the physicalName

fix aws#14337


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-events): event bus doesn't respect physical names
3 participants