Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): Apply tags to log retention Lambda #17029

Merged
merged 4 commits into from Oct 28, 2021

Conversation

jamesorlakin
Copy link
Contributor

This hopefully fixes #15032 by implementing the ITaggable interface on the custom construct and then applying discovered tags to the underlying CfnResource.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 17, 2021

@peterwoodworth peterwoodworth changed the title fix(logs): Apply tags to log retention Lambda fix(logs): Apply tags to log retention Lambda Oct 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-logs Related to Amazon CloudWatch Logs label Oct 21, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 27, 2021

Hi @jamesorlakin, I changed your PR a bit to improve the programming experience for you and other people going forward (by removing the use of prepare()--it shouldn't be necessary).

However, I am unable to push my change back to your branch in order to merge it:

image

Do you have Allow edits from maintainers switched off by any chance?

Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cherry-pick commit c1fd7969c into this PR

@rix0rrr rix0rrr self-requested a review October 27, 2021 15:03
rix0rrr
rix0rrr previously approved these changes Oct 27, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 27, 2021

Nevermind I figured it out

@mergify mergify bot dismissed rix0rrr’s stale review October 27, 2021 15:03

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a6aaa64 into aws:master Oct 28, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 76a1abb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jamesorlakin
Copy link
Contributor Author

Thanks @rix0rrr, your solution is definitely snazzier than mine!

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
This hopefully fixes aws#15032 by implementing the `ITaggable` interface on the custom construct and then applying discovered tags to the underlying `CfnResource`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(logs): Tags are not propagated to LogRetention lambda
3 participants