Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kinesis): add required rights to trigger Lambda from Kinesis. Fixes issue #17312. #17358

Merged
merged 8 commits into from Nov 11, 2021
Merged

Conversation

mprencipe
Copy link
Contributor

Add required rights to trigger Lambda from Kinesis. Fixes issue #17312.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 5, 2021

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Nov 5, 2021
@nija-at nija-at changed the title fix: add required rights to trigger Lambda from Kinesis. Fixes issue #17312. fix(kinesis): add required rights to trigger Lambda from Kinesis. Fixes issue #17312. Nov 5, 2021
@nija-at nija-at added @aws-cdk/aws-kinesis Related to Amazon Kinesis and removed @aws-cdk/aws-lambda Related to AWS Lambda labels Nov 5, 2021
@nija-at nija-at assigned otaviomacedo and unassigned otaviomacedo and nija-at Nov 5, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1f3bd1d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0bfc15c into aws:master Nov 11, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mprencipe mprencipe deleted the fix-17312 branch November 12, 2021 09:22
akash1810 added a commit to guardian/cdk that referenced this pull request Dec 22, 2021
This version follows v49.0.0 of the CloudFormation Resource specification,
which sees tag support added to `AWS::Logs::LogGroup` resources.

It also includes a fix for Kinesis triggered Lambdas,
specifically fixing the permissions needed by the Lambda on the Kinesis stream.

See:
  - https://github.com/aws/aws-cdk/releases/tag/v1.133.0
  - https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/cfnspec/CHANGELOG.md#cloudformation-resource-specification-v4900
  - aws/aws-cdk#17358

BREAKING CHANGE: Update aws-cdk libraries to 1.133.0
akash1810 added a commit to guardian/cdk that referenced this pull request Dec 23, 2021
This version follows v49.0.0 of the CloudFormation Resource specification,
which sees tag support added to `AWS::Logs::LogGroup` resources.

It also includes a fix for Kinesis triggered Lambdas,
specifically fixing the permissions needed by the Lambda on the Kinesis stream.

See:
  - https://github.com/aws/aws-cdk/releases/tag/v1.133.0
  - https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/cfnspec/CHANGELOG.md#cloudformation-resource-specification-v4900
  - aws/aws-cdk#17358

BREAKING CHANGE: Update aws-cdk libraries to 1.133.0
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…es issue aws#17312. (aws#17358)

Add required rights to trigger Lambda from Kinesis. Fixes issue aws#17312.
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-kinesis Related to Amazon Kinesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants