Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): skip bundling for the 'watch' command #17455

Merged
merged 2 commits into from Nov 10, 2021

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Nov 10, 2021

Add watch to the list of commands that require bundling.

Closes #17391


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add `watch` to the list of commands that require bundling.

Closes aws#17391
@gitpod-io
Copy link

gitpod-io bot commented Nov 10, 2021

@jogold
Copy link
Contributor Author

jogold commented Nov 10, 2021

@skinny85

@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Nov 10, 2021
@skinny85 skinny85 changed the title fix(core): bundling skipped with watch fix(cli): bundling skipped with watch Nov 10, 2021
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Nov 10, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 changed the title fix(cli): bundling skipped with watch fix(cli): skip bundling for the 'watch' command Nov 10, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 84156c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit af61b7f into aws:master Nov 10, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Add `watch` to the list of commands that require bundling.

Closes aws#17391


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cli): watch command not working properly with NodeJsFunction
4 participants