Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-neptune): Provide Auto Minor Version Upgrade option for Neptune Cluster instances #17545

Closed
1 of 2 tasks
pedrosola opened this issue Nov 17, 2021 · 3 comments · Fixed by #18394
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@pedrosola
Copy link
Contributor

Description

Using the DatabaseCluster construct, I would like to specify that I want Auto Minor Version Upgrade to be enabled. This is inline with the security checks provided by the cdk-nag. This feature makes it so that projects using the construct are deemed invalid, as per the AWS Solutions Library rules.

More details about the feature can be found at the AWS Documentation.

Use Case

I need this feature for security purposes. Particularly, this is required in order to pass the AwsSolutions-N2 check by the cdk-nag tool. More information on rules can be found here.

Proposed Solution

I see the following approaches:

  1. Provide the auto_minor_version_upgrade property directly under the DatabaseCluster construct as a boolean. If True then every Instance on the cluster would have auto_minor_version_upgrade set to True
  2. Provide the auto_minor_version_upgrade property under the DatabaseClusterProps construct. The rest follows as in (1).
  3. Provide auto_minor_version_upgrade property under the DatabaseInstanceProps construct and, in addition, provide a way for this property to be passed to the DatabaseCluster construct.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@pedrosola pedrosola added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 17, 2021
@github-actions github-actions bot added the @aws-cdk/aws-neptune Related Amazon Neptune label Nov 17, 2021
@njlynch njlynch added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 7, 2021
@njlynch njlynch removed their assignment Dec 7, 2021
@njlynch
Copy link
Contributor

njlynch commented Dec 7, 2021

Thanks for the feature request.

Option 1 seems the sanest in the near-term. This would closely mirror the approach in some of the other DB services (e.g., docdb). Contributions welcome.

In the meantime, you can use escape hatches to set the underlying Cloudformation properties.

@njlynch njlynch added the good first issue Related to contributions. See CONTRIBUTING.md label Dec 7, 2021
@ericzbeard
Copy link
Contributor

This looks fairly simple, I'm going to work on it this week.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants