feat(apigateway): add option to set the base path when adding a domain name to a Rest API #17915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n name to a Rest API
|
|
github-actions
bot
added
the
@aws-cdk/aws-apigateway
otaviomacedo
added
the
pr-linter/exempt-readme
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…n name to a Rest API (aws#17915) If a domain name has an empty base path mapping, API Gateway does not allow the creation of additional base path mappings. The problem is that `addDomainName` always creates an empty base path mapping, preventing users to add their own afterwards. Add a property to define a base path mapping at the same time as adding the domain name. Fixes aws#9581. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a domain name has an empty base path mapping, API Gateway does not allow the
creation of additional base path mappings. The problem is that
addDomainNamealways creates an empty base path mapping, preventing users to add their own
afterwards.
Add a property to define a base path mapping at the same time as adding the
domain name.
Fixes #9581.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license