Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bootstrap): ECR ScanOnPush is now enabled by default #17994

Merged
merged 2 commits into from Jan 4, 2022

Conversation

PatMyron
Copy link
Contributor

AWS::ECR::Repository.ImageScanningConfiguration


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 13, 2021

@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Dec 13, 2021
@rix0rrr rix0rrr changed the title chore(bootstrap): AWS::ECR::Repository.ImageScanningConfiguration.ScanOnPush feat(bootstrap): ECR ScanOnPush is now enabled by default Jan 3, 2022
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you just thumbs-up your own PR 🤓

@PatMyron
Copy link
Contributor Author

PatMyron commented Jan 3, 2022

@rix0rrr figured triaging might sort by it 😛

@rix0rrr rix0rrr added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Jan 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 4aec27c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7588b51 into aws:master Jan 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@PatMyron PatMyron deleted the patch-2 branch January 4, 2022 15:20
@PatMyron
Copy link
Contributor Author

PatMyron commented Jan 6, 2022

@jerry-aws not sure if we want to keep maintaining bootstrap template history in the CDK guide, but heads up just in case

@ghost
Copy link

ghost commented Jan 10, 2022

thanks @PatMyron. I'm not currently tracking that in the Dev Guide, but maybe it'd be a good idea to add a link directly to the template's GitHub history from there. What do you think?

@PatMyron
Copy link
Contributor Author

PatMyron commented Jan 10, 2022

@jerry-aws agreed, think it makes sense to add a link to the template source itself since the template history tables at the bottom are getting outdated otherwise:
https://docs.aws.amazon.com/cdk/v1/guide/bootstrapping.html#bootstrapping-contract
https://docs.aws.amazon.com/cdk/v2/guide/bootstrapping.html#bootstrapping-contract

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
[`AWS::ECR::Repository.ImageScanningConfiguration`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecr-repository.html#cfn-ecr-repository-imagescanningconfiguration)


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package/tools Related to AWS CDK Tools or CLI pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants