Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom-resources): NoEcho for sensitive data in provider framework #18097

Merged
merged 2 commits into from Jan 3, 2022

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Dec 20, 2021

The noEcho option was available in submitResponse() but not exposed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 20, 2021

@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Dec 20, 2021
@jogold jogold changed the title feat(custom-resources): support NoEcho for sensitive data feat(custom-resources): support NoEcho for sensitive data in provider framework Dec 20, 2021
@rix0rrr rix0rrr changed the title feat(custom-resources): support NoEcho for sensitive data in provider framework feat(custom-resources): NoEcho for sensitive data in provider framework Jan 3, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 17127ec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 621a410 into aws:master Jan 3, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jogold jogold deleted the cr-framework-noecho branch January 3, 2022 13:46
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…rk (aws#18097)

The `noEcho` option was available in `submitResponse()` but not exposed.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants