feat(lambda): allow Topic to be dlq for Lambda #18546

kornicameister · 2022-01-19T23:35:52Z

Adds possibility of using sns.Topic as a deadLetterQueue
for a lambda function as described in AWS::Lambda::Function
documentation.

closes: #16246

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Adds possibility of using sns.Topic as a deadLetterQueue for a lambda function as described in `AWS::Lambda::Function` documentation. closes: aws#16246

gitpod-io · 2022-01-19T23:35:54Z

* origin/master: chore(ecr): migrate to Assertions (aws#18538) chore(codepipeline): migrate tests to assertions (aws#18545) chore(cfn-include): migrate all tests to Assertions (aws#18537) chore: move decdk to cdklabs (aws#18529) chore(cloudwatch-actions): migrate to Assertions (aws#18539) chore(globalaccelerator): migrate tests to `assertions` (aws#18532) chore(config): migrate tests to `assertions` (aws#18533) chore(docdb): migrate tests to use the Assertions module (aws#18518) chore: npm-check-updates && yarn upgrade (aws#18528)

kornicameister · 2022-01-20T21:24:13Z

@kaizen3031593 I don't really follow what went wrong now. Any assistance?

packages/@aws-cdk/aws-lambda/lib/function.ts

jumic · 2022-01-21T20:05:56Z

@kornicameister This error message in the build log is relevant:

@aws-cdk/aws-lambda: /codebuild/output/src522368232/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda/test/function.test.ts
@aws-cdk/aws-lambda:   710:15  error  Properties shouldn't be quoted as all quotes are redundant  quote-props
@aws-cdk/aws-lambda:   721:11  error  Properties shouldn't be quoted as all quotes are redundant  quote-props

You have to remove the single quotes from Ref.

Resource: {
  'Ref': 'DeadLetterQueue9F481546',
},

Correct syntax:

Resource: {
  Ref: 'DeadLetterQueue9F481546',
},

FYI: Just in case you don't know: You can also execute the build on your local machine to see the errors before committing the changes.

kornicameister · 2022-01-21T20:33:18Z

I really need to do more TS coding...I didn't connect the dots. Will fix that as soon as I can

* origin/master: (31 commits) feat(iotevents): add DetectorModel L2 Construct (aws#18049) feat(ecs): add `BaseService.fromServiceArnWithCluster()` for use in CodePipeline (aws#18530) docs(s3): remove vestigial documentation (aws#18604) chore(cli): LogMonitor test fails randomly due to Date.now() (aws#18601) chore(codedeploy): migrate tests to use the Assertions module (aws#18585) docs(stepfunctions): fix typo (aws#18583) chore(eks-legacy): migrate tests to `assertions` (aws#18596) fix(cli): hotswap should wait for lambda's `updateFunctionCode` to complete (aws#18536) fix(apigatewayv2): websocket api: allow all methods in grant manage connections (aws#18544) chore(dynamodb): migrate tests to assertions (aws#18560) fix(aws-apigateway): cross region authorizer ref (aws#18444) feat(lambda-nodejs): Allow setting mainFields for esbuild (aws#18569) docs(cfnspec): update CloudFormation documentation (aws#18587) feat(assertions): support for conditions (aws#18577) fix(ecs-patterns): Fix Network Load Balancer Port assignments in ECS Patterns (aws#18157) chore(region-info): ap-southeast-3 (Jakarta) ELBV2_ACCOUNT (aws#18300) fix(pipelines): CodeBuild projects are hard to tell apart (aws#18492) fix(ecs): only works in 'aws' partition (aws#18496) chore(app-delivery): migrate unit tests to Assertions (aws#18574) chore: migrate kaizen3031593's modules to assertions (aws#18205) ...

* origin/master: (74 commits) chore: remove reliance on `decdk` in build system (aws#18760) chore: add repository directory for all packages.json (aws#17203) docs(ecs): correct comment documentation for NetworkMode (aws#17841) feat(ecs): expose image name in container definition (aws#17793) feat(ecr): add server-side encryption configuration (aws#16966) chore(region-info): ap-southeast-3 (Jakarta) ROUTE_53_BUCKET_WEBSITE_ZONE_ID (aws#18110) chore: reassign njlynch's ownership areas (aws#18751) chore(ecs-service-extensions): migrate tests to assertions (aws#18649) chore(s3): Fixed documentation for `InventoryFormat.ORC` (aws#18717) feat(iot): add Action to republish MQTT messages to another MQTT topic (aws#18661) chore(rds): add support for PostgreSQL 14 (aws#18713) fix(core): correctly reference versionless secure parameters (aws#18730) fix(ec2): `UserData.addSignalOnExitCommand` does not work in combination with `userDataCausesReplacement` (aws#18726) fix(vpc): Vpc.fromLookup should throw if subnet group name tag is explicitly given and does not exist (aws#18714) docs(dynamodb): add note around table encryption (aws#18721) chore: override `markdown-it` version (aws#18723) docs(cfnspec): update CloudFormation documentation (aws#18741) chore(release): 1.142.0 chore(lambda-layer-awscli): contains a CLI version with a CVE (aws#18727) chore(lambda-python): remove Pillow dependency (aws#18722) ...

kaizencc

looks good! just a couple minor comments.

packages/@aws-cdk/aws-lambda/README.md

packages/@aws-cdk/aws-lambda/lib/function.ts

packages/@aws-cdk/aws-lambda/test/function.test.ts

Co-authored-by: Kaizen Conroy <36202692+kaizen3031593@users.noreply.github.com>

Pull request has been modified.

* origin/master: (27 commits) chore(eks): deprecate older versions of EKS (aws#18842) fix(tooling): update vscode devcontainer image (aws#18455) chore: npm-check-updates && yarn upgrade (aws#18832) chore(docs): Fix broken md links (aws#18384) chore(lambda-layer-awscli): install awscli with pip and requirements.txt (aws#18800) fix(aws-appsync): Strip unsupported characters from Lambda DataSource (aws#18765) feat(cfnspec): cloudformation spec v55.0.0 (aws#18827) docs(cfnspec): update CloudFormation documentation (aws#18826) chore(cxapi): plugin context provider limited by cx schema (aws#18709) feat(iotevents): add grant method to Input class (aws#18617) chore(cx-api): break circular dependencies (aws#18767) docs(core): clarify that `addOverride` does not change property casing (aws#18687) feat(s3-deployment): deploy data with deploy-time values (aws#18659) docs(cfnspec): update CloudFormation documentation (aws#18808) feat(cli): `cdk diff` works for Nested Stacks (aws#18207) docs(cfnspec): update CloudFormation documentation (aws#18783) chore(lambda-layer-awscli): add update mechanism for AWS CLI (aws#18780) chore(release): 1.143.0 feat(fsx): add support for FSx Lustre Persistent_2 deployment type (aws#18626) feat(amplify): support performance mode in Branch (aws#18598) ...

kornicameister · 2022-02-06T22:25:20Z

Alright @kaizen3031593 I think all comments have been resolved and all changes have been made. Ready for another round.

kaizencc

Almost there, caught me at a good time so here's a quick turnaround :).

packages/@aws-cdk/aws-lambda/lib/function.ts

Co-authored-by: Kaizen Conroy <36202692+kaizen3031593@users.noreply.github.com>

kaizencc

Thanks for the contribution, @kornicameister!

mergify · 2022-02-17T15:00:46Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-02-17T16:06:56Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: d9c0036
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-02-17T16:07:15Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Adds possibility of using sns.Topic as a deadLetterQueue for a lambda function as described in `AWS::Lambda::Function` documentation. closes: aws#16246 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(lambda): allow Topic to be dlq for Lambda

c9b8d0d

Adds possibility of using sns.Topic as a deadLetterQueue for a lambda function as described in `AWS::Lambda::Function` documentation. closes: aws#16246

github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Jan 19, 2022

github-actions bot assigned kaizencc Jan 19, 2022

kornicameister added 3 commits January 20, 2022 10:51

Add sns to package.json

79aea6e

Fix build issues

d48552b

kornicameister force-pushed the feat_16246 branch from 4240df3 to 3e2bcc1 Compare January 20, 2022 09:55

Update readme

0d3026e

jumic reviewed Jan 21, 2022

View reviewed changes

packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved

kornicameister added 3 commits January 22, 2022 19:39

Fix syntax issue

5e083e8

Fix tests

5ba881b

kaizencc added effort/small Small work item – less than a day of effort p2 labels Jan 24, 2022

kornicameister added 2 commits February 1, 2022 10:15

Use deadLetterTopic and deadLetterQueue

71b742c

kaizencc previously requested changes Feb 3, 2022

View reviewed changes

Apply suggestions from code review

925c0c8

Co-authored-by: Kaizen Conroy <36202692+kaizen3031593@users.noreply.github.com>

kornicameister added 3 commits February 6, 2022 22:53

Update documentation

bc71b10

Update code + tests against review

7bdc06a

kaizencc reviewed Feb 6, 2022

View reviewed changes

packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved

kornicameister and others added 2 commits February 6, 2022 23:34

Apply suggestions from code review

8c4666c

Co-authored-by: Kaizen Conroy <36202692+kaizen3031593@users.noreply.github.com>

Merge branch 'master' into feat_16246

0209202

kornicameister added 2 commits February 16, 2022 09:32

Change variable name

0343c83

Merge branch 'master' into feat_16246

e05e410

kaizencc approved these changes Feb 17, 2022

View reviewed changes

Merge branch 'master' into feat_16246

d9c0036

mergify bot merged commit f8d8fe4 into aws:master Feb 17, 2022

kornicameister deleted the feat_16246 branch February 18, 2022 12:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lambda): allow Topic to be dlq for Lambda #18546

feat(lambda): allow Topic to be dlq for Lambda #18546

kornicameister commented Jan 19, 2022

gitpod-io bot commented Jan 19, 2022

kornicameister commented Jan 20, 2022

jumic commented Jan 21, 2022

kornicameister commented Jan 21, 2022

kaizencc left a comment

kornicameister commented Feb 6, 2022

kaizencc left a comment

kaizencc left a comment

mergify bot commented Feb 17, 2022

aws-cdk-automation commented Feb 17, 2022

mergify bot commented Feb 17, 2022

feat(lambda): allow Topic to be dlq for Lambda #18546

feat(lambda): allow Topic to be dlq for Lambda #18546

Conversation

kornicameister commented Jan 19, 2022

gitpod-io bot commented Jan 19, 2022

kornicameister commented Jan 20, 2022

jumic commented Jan 21, 2022

kornicameister commented Jan 21, 2022

kaizencc left a comment

Choose a reason for hiding this comment

kornicameister commented Feb 6, 2022

kaizencc left a comment

Choose a reason for hiding this comment

kaizencc left a comment

Choose a reason for hiding this comment

mergify bot commented Feb 17, 2022

aws-cdk-automation commented Feb 17, 2022

AWS CodeBuild CI Report

mergify bot commented Feb 17, 2022