Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(route53): PublicHostedZone fromPublicHostedZoneAttributes function with zoneName support #18700

Closed
1 of 2 tasks
peterwoodworth opened this issue Jan 27, 2022 · 1 comment · Fixed by #19771
Closed
1 of 2 tasks

(route53): PublicHostedZone fromPublicHostedZoneAttributes function with zoneName support #18700

peterwoodworth opened this issue Jan 27, 2022 · 1 comment · Fixed by #19771
Assignees
@peterwoodworth
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@peterwoodworth
Copy link
Contributor

peterwoodworth commented Jan 27, 2022 •
edited

Description

Support a method called fromPublicHostedZoneAttributes() on PublicHostedZone where you can pass in the zoneName as an attribute

Use Case

VpcEndpointServiceDomainName accepts an IPublicHostedZone, however this will result in an error if you import with the current import method supported by PublicHostedZone.

Proposed Solution

This method would be similar to HostedZone.fromHostedZoneAttributes()

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@peterwoodworth peterwoodworth added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p1 effort/small Small work item – less than a day of effort @aws-cdk/aws-route53 Related to Amazon Route 53 and removed needs-triage This issue or PR still needs to be triaged. labels Jan 27, 2022
@peterwoodworth peterwoodworth mentioned this issue Apr 5, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #19771 Apr 11, 2022
mergify bot pushed a commit that referenced this issue Apr 11, 2022
@peterwoodworth
feat(route53): fromPublicHostedZoneAttributes method with zoneName (#…
7867dc4 
…19771)

fixes #18700

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this issue Apr 27, 2022
@peterwoodworth
feat(route53): fromPublicHostedZoneAttributes method with zoneName (a…
e4d0dcc 
…ws#19771)

fixes aws#18700

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterwoodworth peterwoodworth

Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(route53): fromPublicHostedZoneAttributes method with zoneName aws/aws-cdk
2 participants
@njlynch @peterwoodworth