Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: python3 version check with Python 3.10 #18754

Merged
merged 3 commits into from Feb 16, 2022

Conversation

visadb
Copy link
Contributor

@visadb visadb commented Jan 31, 2022

Fixes #18753


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 31, 2022

rix0rrr
rix0rrr previously approved these changes Feb 8, 2022
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough till Python 3.20 😆

@mergify mergify bot dismissed rix0rrr’s stale review February 9, 2022 14:26

Pull request has been modified.

@visadb visadb requested a review from rix0rrr February 14, 2022 17:42
@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Feb 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f3ccb56
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0ef6527 into aws:master Feb 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Fixes aws#18753

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(core): build.sh: python3 version check does not support python 3.10
3 participants