fix(cli): handle attributes of AWS::Events::EventBus when hotswapping #18834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
skinny85
changed the title
skinny85
force-pushed
the
hotswap-cfn-attributes
branch
from
160fe5b
to
842b679
Compare
skinny85
force-pushed
the
hotswap-cfn-attributes
branch
from
842b679
to
f8bf792
Compare
rix0rrr
approved these changes
Feb 9, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
moelasmar
pushed a commit
to moelasmar/aws-cdk
that referenced
this pull request
Feb 15, 2022
…aws#18834) Without them, customers referencing an `AWS::Events::EventBus` in their StepFunctions StateMachine definition would get this message: ``` Could not perform a hotswap deployment, because the CloudFormation template could not be resolved: We don't support attributes of the 'AWS::Events::EventBus' resource. This is a CDK limitation. Please report it at https://github.com/aws/aws-cdk/issues/new/choose Falling back to doing a full deployment ``` when hotswapping. Fixes aws#18831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…aws#18834) Without them, customers referencing an `AWS::Events::EventBus` in their StepFunctions StateMachine definition would get this message: ``` Could not perform a hotswap deployment, because the CloudFormation template could not be resolved: We don't support attributes of the 'AWS::Events::EventBus' resource. This is a CDK limitation. Please report it at https://github.com/aws/aws-cdk/issues/new/choose Falling back to doing a full deployment ``` when hotswapping. Fixes aws#18831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without them, customers referencing an
AWS::Events::EventBusin their StepFunctions StateMachine definition would get this message:when hotswapping.
Fixes #18831
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license