Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggers: Module not included in 2.14 release #19164

Closed
zandaleph opened this issue Feb 25, 2022 · 2 comments · Fixed by #19168
Closed

Triggers: Module not included in 2.14 release #19164

zandaleph opened this issue Feb 25, 2022 · 2 comments · Fixed by #19168
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 package/tools Related to AWS CDK Tools or CLI

Comments

@zandaleph
Copy link

What is the problem?

I'm trying to use the new triggers functionality which was announced as part of the 2.14.0 release. After upgrading, it does not appear to be present. When I try to import the library via:

import * as triggers from "aws-cdk-lib/triggers";

I get the following error:

TSError: ⨯ Unable to compile TypeScript:
lib/redacted.ts:8:27 - error TS2307: Cannot find module 'aws-cdk-lib/triggers' or its corresponding type declarations.

8 import * as triggers from "aws-cdk-lib/triggers";

Is it possible this was accidentally not included in the 2.14.0 release?

Reproduction Steps

Attempt to import the triggers library as indicated in the problem.

What did you expect to happen?

I would be able to use an announced feature

What actually happened?

I got a compile error for missing module

CDK CLI Version

2.14.0 (build 762d71b)

Framework Version

2.14.0

Node.js Version

v16.14.0

OS

macOS 12.1

Language

Typescript

Language Version

Typescript (~3.9.7)

Other information

Discussed issue in slack before raising issue, relevant thread is https://app.slack.com/client/T017JQ2SWES/C017RG58LM8/thread/C017RG58LM8-1645595484.898189

@zandaleph zandaleph added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 25, 2022
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Feb 25, 2022
@ryparker ryparker added the p1 label Feb 25, 2022
@ryparker
Copy link
Contributor

ryparker commented Feb 25, 2022

Hey @zandaleph 👋🏻

Thank you for reporting this. I've let the team know.

rix0rrr added a commit that referenced this issue Feb 26, 2022
Config that explicitly excluded the package from the v2 build
had slipped in.

Fixes #19164.
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 26, 2022
@rix0rrr rix0rrr removed their assignment Feb 26, 2022
@mergify mergify bot closed this as completed in #19168 Feb 26, 2022
mergify bot pushed a commit that referenced this issue Feb 26, 2022
Config that explicitly excluded the package from the v2 build
had slipped in.

Fixes #19164.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants