Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-s3-notifications): Missing event type equivalent to s3:ObjectRestore:Delete #19223

Closed
2 tasks
mhtrinhLIC opened this issue Mar 3, 2022 · 2 comments · Fixed by #19250
Closed
2 tasks

(aws-s3-notifications): Missing event type equivalent to s3:ObjectRestore:Delete #19223

mhtrinhLIC opened this issue Mar 3, 2022 · 2 comments · Fixed by #19250
Labels
@aws-cdk/aws-s3-notifications effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p1

Comments

@mhtrinhLIC
Copy link

Description

I am trying to get notified when an object that been restored but get expired, thus go back to GLASSIER class.
I could not find the equivalent of s3:ObjectRestore:Delete on https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_aws-s3.EventType.html

Did I missed something ?

Use Case

Get notification when a restored object is expired

Proposed Solution

I am not expert enough but it may be simple as restore post and restore completed already exist.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@mhtrinhLIC mhtrinhLIC added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 3, 2022
@otaviomacedo
Copy link
Contributor

Yes, it's missing. But it should be just a matter of adding a new value to the EventType enum.

@otaviomacedo otaviomacedo added good first issue Related to contributions. See CONTRIBUTING.md p1 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 4, 2022
@otaviomacedo otaviomacedo removed their assignment Mar 4, 2022
@mayforblue mayforblue mentioned this issue Mar 5, 2022
Merged
@mergify mergify bot closed this as completed in #19250 Mar 5, 2022
mergify bot pushed a commit that referenced this issue Mar 5, 2022
@mayforblue
feat(s3): add s3:ObjectRestore:Delete to EventType for notificati…
e0f863a 
…on (#19250)

closes #19223 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Mar 5, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TheRealAmazonKendra pushed a commit to TheRealAmazonKendra/aws-cdk that referenced this issue Mar 11, 2022
@mayforblue @TheRealAmazonKendra
feat(s3): add s3:ObjectRestore:Delete to EventType for notificati…
9242cb7 
…on (aws#19250)

closes aws#19223 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-s3-notifications effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(s3): add s3:ObjectRestore:Delete to EventType for notification mayforblue/aws-cdk
2 participants
@otaviomacedo @mhtrinhLIC