fix(cli): watch logs always end with the 'truncated' message
#19241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudWatchLogs.filterLogEvents will always return a `nextToken` as long as there are _any_ additional logs. This is regardless of any filter used (i.e. `startTime`). This PR updates the logic to only display the truncated message if `CloudWatchLogs.filterLogEvents` returns 100 events (the `limit`) _and_ the `nextToken`. If the limit is hit and there is a `nextToken` then we can assume that the _current_ request for log events was truncated. fixes #18805
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TheRealAmazonKendra
pushed a commit
to TheRealAmazonKendra/aws-cdk
that referenced
this pull request
Mar 11, 2022
…9241) CloudWatchLogs.filterLogEvents will always return a `nextToken` as long as there are _any_ additional logs. This is regardless of any filter used (i.e. `startTime`). This PR updates the logic to only display the truncated message if `CloudWatchLogs.filterLogEvents` returns 100 events (the `limit`) _and_ the `nextToken`. If the limit is hit and there is a `nextToken` then we can assume that the _current_ request for log events was truncated. fixes aws#18805 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudWatchLogs.filterLogEvents will always return a
nextTokenas longas there are any additional logs. This is regardless of any filter
used (i.e.
startTime).This PR updates the logic to only display the truncated message if
CloudWatchLogs.filterLogEventsreturns 100 events (thelimit) and thenextToken. If the limit is hit and there is anextTokenthen we canassume that the current request for log events was truncated.
fixes #18805
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license