Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): migrate from deprecated batch properties #19298

Merged
merged 3 commits into from Mar 11, 2022

Conversation

peterwoodworth
Copy link
Contributor

@peterwoodworth peterwoodworth commented Mar 9, 2022

fixes #18993 + update integ tests


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 9, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 9, 2022
@rix0rrr rix0rrr added bug This issue is a bug. p1 and removed contribution/core This is a PR that came from AWS. labels Mar 9, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 9, 2022
@kaizencc
Copy link
Contributor

@peterwoodworth Since batch is an experimental module, I wonder if we should just remove the containerOverrides option entirely (since that was what was done on the batch side). Perhaps we can expose those properties as an alternative to containerOverrides

@peterwoodworth
Copy link
Contributor Author

I had considered that @kaizen3031593, and actually went with deprecating the properties at first in exchange for what you proposed - but since this change is within the stepfunctions-tasks module I had decided to stick with the easier change at first to see what you would say.

Still, since this change is within a stable module that would require deprecation instead of outright removal, right?

@kaizencc
Copy link
Contributor

Whoops I thought this was in batch. My bad, you're right.

@peterwoodworth
Copy link
Contributor Author

Let me know if you'd like me to go with deprecation 👍🏻

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 556a26a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 75f5b3b into master Mar 11, 2022
@mergify mergify bot deleted the peterwoodworth/sfnBatchDeprecationFix branch March 11, 2022 20:50
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(stepfunctions-task): BatchSubmitJob uses deprecated (and thereby ignored) container overrides API
4 participants