Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(triggers): permissions race condition #19455

Merged
merged 4 commits into from
Jul 7, 2022
Merged

fix(triggers): permissions race condition #19455

merged 4 commits into from
Jul 7, 2022

Conversation

tenjaa
Copy link
Contributor

@tenjaa tenjaa commented Mar 18, 2022 •
edited

fixes #19272

Adding a dependency on the permissions should be good enough

We are planning to use triggers as an e2e test which would run on every deployment.
I wanted to reduce the moving parts and avoid an IAM change each time. Therefore I opted for widening the permission to all versions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 18, 2022

@github-actions github-actions bot added the @aws-cdk/triggers Related to the triggers package label Mar 18, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

otaviomacedo
otaviomacedo previously approved these changes Jun 28, 2022
View reviewed changes
@cecheta cecheta mentioned this pull request Jun 30, 2022
Closed
4 tasks
@tenjaa tenjaa changed the base branch from v1-main to main July 6, 2022 06:57
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Jul 6, 2022
@mergify mergify bot dismissed otaviomacedo’s stale review July 6, 2022 07:36

Pull request has been modified.

@tenjaa
Copy link
Contributor Author

tenjaa commented Jul 6, 2022

@otaviomacedo Could you please re-enable this PR? I resolved the conflicts with the main branch. Thanks in advance!

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@daschaa
Copy link
Contributor

daschaa commented Jul 7, 2022 •
edited

@otaviomacedo The main branch had some updates. Could you update this pr & re-approve it? Would be great! Thanks in advance ❤️

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a2c084b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8ebb81b into aws:main Jul 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
@tenjaa @daschaa
fix(triggers): permissions race condition (aws#19455)
99d4d52 
fixes aws#19272

> Adding a dependency on the permissions should be good enough

We are planning to use triggers as an e2e test which would run on every deployment.
I wanted to reduce the moving parts and avoid an IAM change each time. Therefore I opted for widening the permission to all versions. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees

@otaviomacedo otaviomacedo

Labels
@aws-cdk/triggers Related to the triggers package bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Triggers): Permissions race condition: not authorized to perform: lambda:InvokeFunction
5 participants
@tenjaa @daschaa @aws-cdk-automation @otaviomacedo @TheRealAmazonKendra