fix(autoscaling): update validation on maxInstanceLifetime #19584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-autoscaling
|
Originally, a lower bound of |
rix0rrr
previously requested changes
Mar 31, 2022
| if (this.maxInstanceLifetime && | ||
| (this.maxInstanceLifetime.toSeconds() < 604800 || this.maxInstanceLifetime.toSeconds() > 31536000)) { | ||
| throw new Error('maxInstanceLifetime must be between 7 and 365 days (inclusive)'); | ||
| (this.maxInstanceLifetime.toSeconds() !== 0) && |
There was a problem hiding this comment.
You have to also check for this to be unresolved (!this.maxInstanceLifetime.isUnresolved())
There was a problem hiding this comment.
Sure, will update.
This patch fixes bugs in maxInstanceLifetime validation logic.
|
Changes since the first revision:
|
rix0rrr
approved these changes
Apr 8, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
otaviomacedo
pushed a commit
that referenced
this pull request
Apr 11, 2022
### Summary This patch fixes the following bugs in `maxInstanceLifetime` validation by aligning with [CFN doc](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-maxinstancelifetime): - A lower bound of `maxInstanceLifetime` is 1 day, not 7-days. - `maxInstanceLifetime` can have 0 which is used to clear a previously set value. ### Test - Run unit test. ``` PASS test/auto-scaling-group.test.js =============================== Coverage summary =============================== Statements : 93.11% ( 419/450 ) Branches : 86.93% ( 286/329 ) Functions : 91.81% ( 101/110 ) Lines : 92.84% ( 402/433 ) ================================================================================ ``` - Deploy CFN template having `maxInstanceLifetime` as 86,400 and 0. ### Notes Originally, this issue was reported by #12588. ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
### Summary This patch fixes the following bugs in `maxInstanceLifetime` validation by aligning with [CFN doc](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-maxinstancelifetime): - A lower bound of `maxInstanceLifetime` is 1 day, not 7-days. - `maxInstanceLifetime` can have 0 which is used to clear a previously set value. ### Test - Run unit test. ``` PASS test/auto-scaling-group.test.js =============================== Coverage summary =============================== Statements : 93.11% ( 419/450 ) Branches : 86.93% ( 286/329 ) Functions : 91.81% ( 101/110 ) Lines : 92.84% ( 402/433 ) ================================================================================ ``` - Deploy CFN template having `maxInstanceLifetime` as 86,400 and 0. ### Notes Originally, this issue was reported by aws#12588. ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch fixes the following bugs in
maxInstanceLifetimevalidation by aligning with CFN doc:maxInstanceLifetimeis 1 day, not 7-days.maxInstanceLifetimecan have 0 which is used to clear a previously set value.Test
maxInstanceLifetimeas 86,400 and 0.Notes
Originally, this issue was reported by #12588.
All Submissions:
Adding new Unconventional Dependencies:
New Features
cdk-integto deploy the infrastructure and generate the snapshot (i.e.cdk-integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license