fix(core): exportValue does not work on number attributes #19818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number attributes go through two levels of encoding:
- L1: because of lack of type information, all attributes are assumed to
be `string`s, so we do `Token.asString(new CfnReference(...))`.
- L2: we recast select attributes to numbers by doing `Token.asNumber()`.
The end result is a Token that looks like:
```ts
asNumber(Intrinsic(asString(CfnReference({ 'Fn::GetAtt': [...] }))))
```
When we do `Tokenization.reverse()` on the number, we only reverse
the *first* encoding one layer, leaving us with an `Intrinsic` instead
of the original `CfnReference`. `exportValue()` then rejects the value
as not being the right type of token.
Solution: before encoding, try to decode the given value so we always
encode the innermost token, and not any of the inbetween ones.
Fixes #19537.
|
|
github-actions
bot
added
bug
otaviomacedo
approved these changes
Apr 8, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
otaviomacedo
pushed a commit
that referenced
this pull request
Apr 11, 2022
Number attributes go through two levels of encoding:
- L1: because of lack of type information, all attributes are assumed to
be `string`s, so we do `Token.asString(new CfnReference(...))`.
- L2: we recast select attributes to numbers by doing `Token.asNumber()`.
The end result is a Token that looks like:
```ts
asNumber(Intrinsic(asString(CfnReference({ 'Fn::GetAtt': [...] }))))
```
When we do `Tokenization.reverse()` on the number, we only reverse
the *first* encoding one layer, leaving us with an `Intrinsic` instead
of the original `CfnReference`. `exportValue()` then rejects the value
as not being the right type of token.
Solution: before encoding, try to decode the given value so we always
encode the innermost token, and not any of the inbetween ones.
Fixes #19537.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
Number attributes go through two levels of encoding:
- L1: because of lack of type information, all attributes are assumed to
be `string`s, so we do `Token.asString(new CfnReference(...))`.
- L2: we recast select attributes to numbers by doing `Token.asNumber()`.
The end result is a Token that looks like:
```ts
asNumber(Intrinsic(asString(CfnReference({ 'Fn::GetAtt': [...] }))))
```
When we do `Tokenization.reverse()` on the number, we only reverse
the *first* encoding one layer, leaving us with an `Intrinsic` instead
of the original `CfnReference`. `exportValue()` then rejects the value
as not being the right type of token.
Solution: before encoding, try to decode the given value so we always
encode the innermost token, and not any of the inbetween ones.
Fixes aws#19537.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number attributes go through two levels of encoding:
be
strings, so we doToken.asString(new CfnReference(...)).Token.asNumber().The end result is a Token that looks like:
When we do
Tokenization.reverse()on the number, we only reversethe first encoding one layer, leaving us with an
Intrinsicinsteadof the original
CfnReference.exportValue()then rejects the valueas not being the right type of token.
Solution: before encoding, try to decode the given value so we always
encode the innermost token, and not any of the inbetween ones.
Fixes #19537.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license