fix(cli): stack monitor prints over error messages #19859
Conversation
In #19742, we limited the amount of text that the status printer would produce, and tried to get rid of the empty lines at the end of the rewritable block as well. Unfortunately, we scrolled up too far, overwriting the error messages that may occur during resource provisioning. Since these were the only place where error messages were displayed, it is now not possible to see why a stack deployment fails. This PR fixes that.
|
|
rix0rrr
changed the title
| if (hasErrorMessage(res.event.ResourceStatus ?? '')) { | ||
| debugger; | ||
| } |
There was a problem hiding this comment.
Did you mean for this to remain here?
It's okay if so, but then I'd kind of like a comment above to explain what this is here to help diagnose, so it can be removed once this investigation is done-done-done.
There was a problem hiding this comment.
Whoops. Je suis un idiot.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
In aws#19742, we limited the amount of text that the status printer would produce, and tried to get rid of the empty lines at the end of the rewritable block as well. Unfortunately, we scrolled up too far, overwriting the error messages that may occur during resource provisioning. Since these were the only place where error messages were displayed, it is now not possible to see why a stack deployment fails. This PR fixes that. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
In #19742, we limited the amount of text that the status printer
would produce, and tried to get rid of the empty lines at the end
of the rewritable block as well.
Unfortunately, we scrolled up too far, overwriting the error messages
that may occur during resource provisioning. Since these were the only
place where error messages were displayed, it is now not possible to see
why a stack deployment fails.
This PR fixes that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license