(aws-ecr-assets): image-asset tests that use toBeDefined() are broken

[johns1342]

Describe the bug

The tests that use toBeDefined() cannot fail because fs.existsSync() returns true or false, and both values are defined.

Expected Behavior

The dockerignore test should have failed if I removed the .dockerignore file.

aws-cdk/packages/@aws-cdk/aws-ecr-assets/test/image-asset.test.ts

Lines 374 to 390 in 4cb3b2b

	function testDockerDirectoryIsStagedWithoutFilesSpecifiedInDockerignore(app: App, ignoreMode?: IgnoreMode) {
	const stack = new Stack(app);
	const image = new DockerImageAsset(stack, 'MyAsset', {
	ignoreMode,
	directory: path.join(__dirname, 'dockerignore-image'),
	});
	const session = app.synth();
	// .dockerignore itself should be included in output to be processed during docker build
	expect(fs.existsSync(path.join(session.directory, `asset.${image.assetHash}`, '.dockerignore'))).toBeDefined();
	expect(fs.existsSync(path.join(session.directory, `asset.${image.assetHash}`, 'Dockerfile'))).toBeDefined();
	expect(fs.existsSync(path.join(session.directory, `asset.${image.assetHash}`, 'index.py'))).toBeDefined();
	expect(!fs.existsSync(path.join(session.directory, `asset.${image.assetHash}`, 'foobar.txt'))).toBeDefined();
	expect(fs.existsSync(path.join(session.directory, `asset.${image.assetHash}`, 'subdirectory'))).toBeDefined();
	expect(fs.existsSync(path.join(session.directory, `asset.${image.assetHash}`, 'subdirectory', 'baz.txt'))).toBeDefined();
	}

Current Behavior

If you delete a .dockerignore file, the tests still pass.

Reproduction Steps

cd packages/@aws-cdk/aws-ecr-assets
rm test/dockerignore-image/.dockerignore
yarn build && yarn test

This line should cause a test to fail, but it doesn't:

aws-cdk/packages/@aws-cdk/aws-ecr-assets/test/image-asset.test.ts

Line 387 in 4cb3b2b

expect(!fs.existsSync(path.join(session.directory, `asset.${image.assetHash}`, 'foobar.txt'))).toBeDefined();

Possible Solution

Change .toBeDefined() to .toBe(true).

Additional Information/Context

I ran into this when testing out a PR for issue #17686 and realized that I couldn't make the test fail.

CDK CLI Version

2.20.0 (build 738ef49)

Framework Version

HEAD 4cb3b2b

Node.js Version

v14.15.4

OS

Darwin / Monterey 12.1

Language

Typescript

Language Version

TypeScript (3.9.10)

Other information

No response

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.