(s3-deployment): BucketDeployment ephemeral storage for internal lambda #19947
Labels
@aws-cdk/aws-lambda
Related to AWS Lambda
@aws-cdk/aws-s3-deployment
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p1
Comments
krisztianpinter
added
feature-request
kaizencc
added
p1
effort/small
4 tasks
kaizencc
changed the title
mergify bot
pushed a commit
that referenced
this issue
Apr 20, 2022
…yment (#19958) Closes #19947. Followed the same convention for `memoryLimit` property so that a new singleton lambda configuration will be created when bucket deployments are specified with different `ephemeralStorageSize` configurations. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this issue
Apr 27, 2022
…yment (aws#19958) Closes aws#19947. Followed the same convention for `memoryLimit` property so that a new singleton lambda configuration will be created when bucket deployments are specified with different `ephemeralStorageSize` configurations. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
Lambda now has ephemeral storage size, which was added #19605. However, BucketDeployment creates a lambda function internally, and this setting is missing from there.
Use Case
Uploading big files is only possible via EFS volumes and VPC setup, as it hits ephemeral disk limit. Now we don't have to deal with this limitation anymore.
Proposed Solution
Add the parameter to BucketDeployment constructor, as was added to the lambda Function constructor, and similarly how memory size is present in the BucketDeyployment constructor already.
Other Information
No response
Acknowledgements
CDK version used
2.20.0 (build 738ef49)
Environment details (OS name and version, etc.)
Linux Mint 19
The text was updated successfully, but these errors were encountered: