Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iot-actions) Add support for the dynamodbv2 action #20162

Closed
1 of 2 tasks
bobveringa opened this issue May 1, 2022 · 2 comments · Fixed by #20171
Closed
1 of 2 tasks

(iot-actions) Add support for the dynamodbv2 action #20162

bobveringa opened this issue May 1, 2022 · 2 comments · Fixed by #20171
Labels
@aws-cdk/aws-iot-actions effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@bobveringa
Copy link
Contributor

bobveringa commented May 1, 2022

Describe the feature

AWS CDK has no support for the dynamoDBv2 riot rule action.

Use Case

I am working on implementing a solution that requires this rule. Using couldformation resources would be possible, but adding in support would be a lot easier.

Proposed Solution

It seems like this would be a small addition with a low effort. There are already similar rules implemented.

It would add a rule called DynamoDBv2PutAction that takes a dynamodb.ITable as argument.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.20

Environment details (OS name and version, etc.)

windows 10

@bobveringa bobveringa added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 1, 2022
@github-actions github-actions bot added the @aws-cdk/aws-iot Related to AWS IoT label May 1, 2022
@skinny85
Copy link
Contributor

skinny85 commented May 2, 2022

Thanks for the feature request, and the PR @bobveringa!

@skinny85 skinny85 added p2 effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs and removed needs-triage This issue or PR still needs to be triaged. labels May 2, 2022
@skinny85 skinny85 removed their assignment May 2, 2022
@skinny85 skinny85 added @aws-cdk/aws-iot-actions and removed @aws-cdk/aws-iot Related to AWS IoT labels May 2, 2022
@skinny85 skinny85 changed the title (aws-iot-alpha) Add support for the dynamodbv2 action (iot-actions) Add support for the dynamodbv2 action May 2, 2022
@mergify mergify bot closed this as completed in #20171 Aug 2, 2022
mergify bot pushed a commit that referenced this issue Aug 2, 2022
This merge request adds the dynamodbv2 IoT rule action as a new feature. This rule is useful for quickly logging device information into DynamoDB. Furthermore, it adds some other important functionality as IoT action.

Closes #20162

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

josephedward pushed a commit to josephedward/aws-cdk that referenced this issue Aug 30, 2022
This merge request adds the dynamodbv2 IoT rule action as a new feature. This rule is useful for quickly logging device information into DynamoDB. Furthermore, it adds some other important functionality as IoT action.

Closes aws#20162

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iot-actions effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants