Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large Apps Fail on writing manifest.json #20211

Closed
comcalvi opened this issue May 4, 2022 · 1 comment · Fixed by #20387 or #20433
Closed

Large Apps Fail on writing manifest.json #20211

comcalvi opened this issue May 4, 2022 · 1 comment · Fixed by #20387 or #20433
Labels
bug This issue is a bug. p1

Comments

@comcalvi
Copy link
Contributor

comcalvi commented May 4, 2022

In Apps with large numbers of resources (600K+) the manifest.json file becomes to large for JSON.stringify() to handle.
@comcalvi comcalvi added bug This issue is a bug. p1 labels May 6, 2022
@comcalvi comcalvi mentioned this issue May 17, 2022
Merged
@mergify mergify bot closed this as completed in #20387 May 18, 2022
mergify bot pushed a commit that referenced this issue May 18, 2022
@comcalvi
feat(core): allow disabling of LogicalID Metadata in case of large ma…
dc9536a 
…nifest (#20387)

Users have encountered an error resulting from the manifest being too large to stringify. This allows users to prevent this metadata from ever being added to the manifest. 

Fixes #20211.

----


*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@comcalvi comcalvi mentioned this issue May 20, 2022
Merged
mergify bot pushed a commit that referenced this issue May 20, 2022
@comcalvi
feat(core): allow disabling of LogicalID Metadata in case of large m…
88ea829 
…anifest (#20433)

Users have encountered an error resulting from the manifest being too large to stringify. This allows users to prevent this metadata from ever being added to the manifest. Fixes the issue that caused the previous iteration of this PR to fail in the v2 pipeline.

Fixes #20211.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
wphilipw pushed a commit to wphilipw/aws-cdk that referenced this issue May 23, 2022
@comcalvi @wphilipw
feat(core): allow disabling of LogicalID Metadata in case of large ma…
489eff3 
…nifest (aws#20387)

Users have encountered an error resulting from the manifest being too large to stringify. This allows users to prevent this metadata from ever being added to the manifest. 

Fixes aws#20211.

----


*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
wphilipw pushed a commit to wphilipw/aws-cdk that referenced this issue May 23, 2022
@comcalvi @wphilipw
feat(core): allow disabling of LogicalID Metadata in case of large m…
6cd8af7 
…anifest (aws#20433)

Users have encountered an error resulting from the manifest being too large to stringify. This allows users to prevent this metadata from ever being added to the manifest. Fixes the issue that caused the previous iteration of this PR to fail in the v2 pipeline.

Fixes aws#20211.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. p1
Projects
None yet
Milestone
No milestone
1 participant
@comcalvi