Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(S3): (miss implementation of objectSizeGreaterThan and objectSizeLessThan in LifecycleRule interface) #20372

Closed
2 tasks
BDeus opened this issue May 17, 2022 · 2 comments
Assignees
Labels
@aws-cdk/aws-s3 Related to Amazon S3 feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@BDeus
Copy link
Contributor

BDeus commented May 17, 2022

Describe the feature

Missing the implementation of the property objectSizeGreaterThan and objectSizeLessThan in layer 2 LifecycleRule

Use Case

This force us to use the Cfn Layer 1 implementation for both of Lifecycle and Bucket.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.24.1

Environment details (OS name and version, etc.)

windows

@BDeus BDeus added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 17, 2022
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label May 17, 2022
mergify bot pushed a commit that referenced this issue May 25, 2022
…20425)

Fixes (first half) of #20372. 
This implements the `objectSizeGreaterThan` property for a S3 lifecycle rule. 

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this issue May 31, 2022
)

Fixes (other half - see #20425) of #20372.
This implements the `objectSizeLessThan` property for a S3 lifecycle rule.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@BDeus
Copy link
Contributor Author

BDeus commented Jun 1, 2022

thanks @daschaa

@BDeus BDeus closed this as completed Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3 Related to Amazon S3 feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants