feat(lambda): inline function code can exceed 4096 bytes

[seyeong]

CloudFormation removed the 4k charcaters limit for inline function code.

Latest public documentation: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-function-code.html#cfn-lambda-function-code-zipfile

Historic documentation: https://web.archive.org/web/20220309033724/https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-function-code.html#cfn-lambda-function-code-zipfile

Internal Code Review reference: CR-53662636

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• This PR adds new unconventional dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[kaizencc]

Thanks for the documentation on this change @seyeong. Just to be sure, I would like to test this in an integ test (maybe in integ.lambda.ts) just to be sure that it will deploy with > 4096 bytes

[seyeong]

@kaizencc Can you please help me understand why you're requesting an integer test? I don't see a point adding it.

[kaizencc]

@seyeong for peace of mind. you're loosening a behavior that previously would have resulted in a failed deployment. it stands that we should check that the deployment will not fail before removing the check.

[seyeong]

it stands that we should check that the deployment will not fail before removing the check.

The check can be done manually. To me, it feels like we're producing a tech debt by add it to the integration test. I personally test it myself and you can do it as well. If you still think that it is necessary to add an automated test, let me know.

Pull request has been modified.

[kaizencc]

The important thing is to have tested a deployment of this code (beyond what a unit test can do). Documenting that you have done so on this PR is enough for me.

[TheRealAmazonKendra]

We need an update to the README for this change. fromInline still documents this limit. Please also verify that you have manually tested this change and we can remove the label requiring the integration test.

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 6f63ce2
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).