Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-certificatemanager): DnsValidatedCertificate created without tags from Stack #20698

Closed
ChrisLane opened this issue Jun 10, 2022 · 2 comments
Closed

(aws-certificatemanager): DnsValidatedCertificate created without tags from Stack #20698

ChrisLane opened this issue Jun 10, 2022 · 2 comments
Labels
@aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort needs-reproduction This issue needs reproduction. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@ChrisLane
Copy link

Describe the bug

Unlike all my other resources ,when I create a certificate using DnsValidatedCertificate tags from the stack are not added to the certificate.

Expected Behavior

Tags from the parent stack should be added to certificates created with DnsValidatedCertificate

Current Behavior

Tags from the parent stack are not currently added to certificates created with DnsValidatedCertificate

Reproduction Steps

Create a certificate with DnsValidatedCertificate in a Stack that has tags.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.27.0 (build 8e89048)

Framework Version

No response

Node.js Version

v18.3.0

OS

Linux 5.18.2-zen1-1-zen

Language

Typescript

Language Version

No response

Other information

No response
@ChrisLane ChrisLane added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 10, 2022
@github-actions github-actions bot added the @aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager label Jun 10, 2022
@comcalvi comcalvi added the effort/small Small work item – less than a day of effort label Jun 20, 2022
@comcalvi comcalvi removed their assignment Jun 20, 2022
@comcalvi comcalvi added the p2 label Jun 20, 2022
@peterwoodworth peterwoodworth removed the needs-triage This issue or PR still needs to be triaged. label Jul 12, 2022
@corymhall corymhall mentioned this issue Sep 9, 2022
Merged
4 tasks
@corymhall
Copy link
Contributor

@ChrisLane can you provide a reproducible example? DnsValidatedCertificate does have support for adding tags.

@corymhall corymhall added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. needs-reproduction This issue needs reproduction. labels Sep 20, 2022
@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Sep 22, 2022
mergify bot pushed a commit that referenced this issue Jan 25, 2023
@corymhall
feat(certificatemanager): deprecate DnsValidatedCertificate (#21982)
64bfbf9 
Now that the official CloudFormation resource `AWS::CertificateManager::Certificate` (CDK's `Certificate` construct) supports DNS validation we do not want to recommend using the `DnsValidatedCertificate` construct.

The `DnsValidatedCertificate` construct uses CloudFormation custom resources to perform the certificate creation and this creates a lot of maintenance burden on our team (see the list of linked issues). Currently the primary use case for using `DnsValidatedCertificate` over `Certificate` is for cross region use cases. For this use case I have updated the README to have our suggested solution.

The example in the README is tested in this [integration test](https://github.com/aws/aws-cdk/blob/main/packages/@aws-cdk/aws-cloudfront/test/integ.cloudfront-cross-region-cert.ts)

fixes #8934, #2914, #20698, #17349, #15217, #14519


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort needs-reproduction This issue needs reproduction. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ChrisLane @corymhall @peterwoodworth @comcalvi