Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@aws-cdk/aws-s3 : s3 bucket python version upgrade #20973

Closed
2 tasks
mykoladevis opened this issue Jul 4, 2022 · 2 comments · Fixed by #23209
Closed
2 tasks

@aws-cdk/aws-s3 : s3 bucket python version upgrade #20973

mykoladevis opened this issue Jul 4, 2022 · 2 comments · Fixed by #23209
Assignees
@indrora
Labels
@aws-cdk/aws-s3 Related to Amazon S3 dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@mykoladevis
Copy link

Describe the feature

Upgrade python version notification wrapper from 3.7 to 3.9

Use Case

AWS notified already about upgrading from 3.6 to 3.9. After upgrading my lambdas to 3.9 I've noticed that this internal lambda is still on 3.7.
Could we, please, upgrade this one to 3.9 too

Proposed Solution

On line

aws-cdk/packages/@aws-cdk/aws-s3/lib/notifications-resource/notifications-resource-handler.ts

Line 104 in 5e0b6c4

Runtime: 'python3.7',

change to Runtime to:

python3.9

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.29.0

Environment details (OS name and version, etc.)

Ubuntu 20.04.4 LTS
@mykoladevis mykoladevis added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 4, 2022
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Jul 4, 2022
@indrora indrora added good first issue Related to contributions. See CONTRIBUTING.md p1 dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. and removed feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 20, 2022
@indrora indrora self-assigned this Jul 20, 2022
@otaviomacedo
Copy link
Contributor

@mykoladevis would you be interested in submitting a contribution for this one? You can find more information on the contributing guide.

@otaviomacedo otaviomacedo removed their assignment Aug 5, 2022
@ghost ghost mentioned this issue Aug 5, 2022
Closed
4 tasks
@watany-dev watany-dev mentioned this issue Dec 2, 2022
Merged
4 tasks
@mrgrain mrgrain added p2 and removed p1 labels Dec 5, 2022
@mergify mergify bot closed this as completed in #23209 Dec 7, 2022
mergify bot pushed a commit that referenced this issue Dec 7, 2022
@watany-dev
feat(s3): update runtime of notifications-handler to python3.9 (#23209)
b2d293d 
closes #20973

This upgrades the runtime of the internal function `notifications-resource-handler` from Python 3.7 to Python 3.9

Referring to the PR below
#21483

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Dec 9, 2022
@watany-dev
feat(s3): update runtime of notifications-handler to python3.9 (aws#2…
d7fc12c 
…3209)

closes aws#20973

This upgrades the runtime of the internal function `notifications-resource-handler` from Python 3.7 to Python 3.9

Referring to the PR below
aws#21483

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Jan 20, 2023
@watany-dev
feat(s3): update runtime of notifications-handler to python3.9 (aws#2…
fe8dc09 
…3209)

closes aws#20973

This upgrades the runtime of the internal function `notifications-resource-handler` from Python 3.7 to Python 3.9

Referring to the PR below
aws#21483

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this issue Feb 22, 2023
@watany-dev
feat(s3): update runtime of notifications-handler to python3.9 (aws#2…
a033d8b 
…3209)

closes aws#20973

This upgrades the runtime of the internal function `notifications-resource-handler` from Python 3.7 to Python 3.9

Referring to the PR below
aws#21483

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indrora indrora

Labels
@aws-cdk/aws-s3 Related to Amazon S3 dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
4 participants
@otaviomacedo @mrgrain @indrora @mykoladevis