fix(pipelines): cannot publish assets to more than 35 environments #21010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to use `Lazy.list()` to render the list of Role ARNs that the Asset Publishing Role needs to assume. The Lazy list cannot be split up, meaning the overflow rendering logic we recently added cannot apply to this policy. Turn the lazy list into mutating a policy statement in-place, so the policy overflow logic can split the policy statement into multiple managed policies.
|
|
RomainMuller
approved these changes
Jul 7, 2022
| @@ -488,10 +489,10 @@ class AssetPublishing extends Construct { | |||
| private readonly MAX_PUBLISHERS_PER_STAGE = 50; | |||
|
|
|||
| private readonly publishers: Record<string, PublishAssetsAction> = {}; | |||
| private readonly assetRoles: Record<string, iam.IRole> = {}; | |||
Co-authored-by: Romain Marcadier <rmuller@amazon.com>
Co-authored-by: Romain Marcadier <rmuller@amazon.com>
Co-authored-by: Romain Marcadier <rmuller@amazon.com>
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
…ws#21010) We used to use `Lazy.list()` to render the list of Role ARNs that the Asset Publishing Role needs to assume. The Lazy list cannot be split up, meaning the overflow rendering logic we recently added cannot apply to this policy. Turn the lazy list into mutating a policy statement in-place, so the policy overflow logic can split the policy statement into multiple managed policies. Also in this PR: - To keep the tests behavior consistent (on whether arrays get rendered to the `Resource` field in statements or not, regardless of exactly which code path is taken), change the behavior of `PolicyStatement`, have it eagerly dedupe in memory. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to use
Lazy.list()to render the list of Role ARNs that theAsset Publishing Role needs to assume.
The Lazy list cannot be split up, meaning the overflow rendering logic
we recently added cannot apply to this policy. Turn the lazy list into
mutating a policy statement in-place, so the policy overflow logic can
split the policy statement into multiple managed policies.
Also in this PR:
Resourcefield in statements or not, regardless of exactly which code path is taken), change the behavior ofPolicyStatement, have it eagerly dedupe in memory.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license