Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): asset fingerprint cache invalidation incorrectly uses mtime #21374

Merged
merged 7 commits into from
Jul 29, 2022
Merged

fix(core): asset fingerprint cache invalidation incorrectly uses mtime #21374

merged 7 commits into from
Jul 29, 2022

Conversation

RomainMuller
Copy link
Contributor

Instead of using the complete mtime value, it only accounted for the day-of-month
and fractional seconds part of the timestamp, which is not the intention.

The issue was introduced in #21321

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@RomainMuller
fix(core): asset fingerprint cache invalidation incorrectly uses mtime
c2e8998 
Instead of using the complete mtime value, it only accounted for the day-of-month
and fractional seconds part of the timestamp, which is not the intention.
@gitpod-io
Copy link

gitpod-io bot commented Jul 29, 2022

@github-actions github-actions bot added the p2 label Jul 29, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 29, 2022 11:04
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 29, 2022
@RomainMuller RomainMuller added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 29, 2022
@RomainMuller RomainMuller merged commit 65a210a into main Jul 29, 2022
@RomainMuller RomainMuller deleted the rmuller/fix-cache-fingerprint branch July 29, 2022 13:33
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 22308de
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurelmay laurelmay mentioned this pull request Aug 3, 2022
Merged
4 tasks
josephedward pushed a commit to josephedward/aws-cdk that referenced this pull request Aug 30, 2022
@RomainMuller @josephedward
fix(core): asset fingerprint cache invalidation incorrectly uses mtime (
2e42c72 
aws#21374)

Instead of using the complete mtime value, it only accounted for the day-of-month
and fractional seconds part of the timestamp, which is not the intention.

The issue was introduced in aws#21321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomainMuller @aws-cdk-automation