Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events-targets): add dlq support for ecs target #21396

Merged
merged 3 commits into from Aug 1, 2022
Merged

feat(events-targets): add dlq support for ecs target #21396

merged 3 commits into from Aug 1, 2022

Conversation

jumic
Copy link
Contributor

@jumic jumic commented Jul 31, 2022

Add DLQ support for ECS target.

Closes #21118.

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 31, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team July 31, 2022 10:08
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 labels Jul 31, 2022
TheRealAmazonKendra
TheRealAmazonKendra previously requested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost perfect, but can you update these integration tests to use the new IntegTest type. Here's the documentation for that.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review August 1, 2022 21:28

Pull request has been modified.

@jumic
Copy link
Contributor Author

jumic commented Aug 1, 2022

I updated the integration tests to the new type. In addition, I renamed integ.event-ec2-task.lit.ts to integ.event-ec2-task.ts because it's not used in the documentation.

TheRealAmazonKendra
TheRealAmazonKendra requested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

TheRealAmazonKendra
TheRealAmazonKendra approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooooops. I hit the wrong button. Approving, not requesting changes.

@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(events-targets): Add DLQ support for ECS target feat(events-targets): add dlq support for ecs target Aug 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6698299
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e82ba52 into aws:main Aug 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

josephedward pushed a commit to josephedward/aws-cdk that referenced this pull request Aug 30, 2022
@jumic @josephedward
feat(events-targets): add dlq support for ecs target (aws#21396)
aae4ff2 
Add DLQ support for ECS target.

Closes aws#21118.

----

### All Submissions:

* [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [X] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [X] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

events-targets: dead letter queue for an ECS task target
3 participants
@jumic @aws-cdk-automation @TheRealAmazonKendra