Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Batch: Need support for more JobDefinition attributes #21740

Closed
2 tasks
rjuengling-hf opened this issue Aug 24, 2022 · 2 comments · Fixed by #21904
Closed
2 tasks

AWS Batch: Need support for more JobDefinition attributes #21740

rjuengling-hf opened this issue Aug 24, 2022 · 2 comments · Fixed by #21904
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@rjuengling-hf
Copy link

Describe the feature

Support more JobDefinition attributes in the AWS Batch CDK module.

In particular, I need to be able to set the propagateTags attribute.

Use Case

Attribution of costs and real-time monitoring.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.38.0-alpha.0

Environment details (OS name and version, etc.)

CentOS 7
@rjuengling-hf rjuengling-hf added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 24, 2022
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label Aug 24, 2022
@rjuengling-hf rjuengling-hf changed the title (module name): (short issue description) AWS Batch: Need support for more JobDefinition attributes Aug 24, 2022
@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 27, 2022
@peterwoodworth
Copy link
Contributor

Thanks for reporting this request,

You can currently set this with escape hatches by accessing the generated L1 CfnJobDefinition and setting any properties seen here

We accept contributions! Check out our contributing guide if you're interested - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂

@jmortlock jmortlock mentioned this issue Sep 2, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #21904 Sep 3, 2022
mergify bot pushed a commit that referenced this issue Sep 3, 2022
@jmortlock
feat(batch): add propagate tags prop in job definition (#21904)
1bc4526 
Closes: #21740 

Add support for propagateTags to the CDK construct.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Sep 3, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hacker65536 pushed a commit to hacker65536/aws-cdk that referenced this issue Sep 30, 2022
@jmortlock @hacker65536
feat(batch): add propagate tags prop in job definition (aws#21904)
e0bd8a6 
Closes: aws#21740 

Add support for propagateTags to the CDK construct.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(batch): add propagate tags prop in job definition jmortlock/aws-cdk
3 participants
@peterwoodworth @madeline-k @rjuengling-hf