aws-events-targets: retryAttempts = 0 does not work as intended

[sunhyung]

Describe the bug

Hi team,

I am working on EventBridge via CDK and got an issue with retryAttempts property.
After creating a rule, I tried to set a target with retryAttempts = 0 but CDK has set retryAttempts as default value instead of 0.

Expected Behavior

      myRule.addTarget(
        new targets.LambdaFunction(myLambda, {
          retryAttempts: 0,
          ...

This code should set retryAttempts value as 0.

Current Behavior

Instead of setting 0, the code set retryAttempts as default value which is 185.

Reproduction Steps

1. Create a rule.
2. Set a target with retryAttempts = 0.
3. Deploy a stack.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.39.1

Framework Version

No response

Node.js Version

16.13.1

OS

MS Windows 10

Language

Typescript

Language Version

TypeScript (3.9.10)

Other information

No response

[sunhyung]

When I add maxEventAge explicitly, the rule would have the right retryAttempts value even though I put Duration.hours(24) to maxEventAge which is the default value of maxEventAge.
But I think the rule should have retryAttempts = 0 without explicit maxEventAge setting.

 myRule.addTarget(
        new targets.LambdaFunction(myLambda, {
          retryAttempts: 0,
          maxEventAge: Duration.hours(24),
          ...

[peterwoodworth]

The culprit is right here

aws-cdk/packages/@aws-cdk/aws-events-targets/lib/util.ts

Lines 54 to 59 in c607ca5

	retryPolicy: retryAttempts || maxEventAge
	? {
	maximumRetryAttempts: retryAttempts,
	maximumEventAgeInSeconds: maxEventAge?.toSeconds({ integral: true }),
	}
	: undefined,

0 is a falsy value, but still a valid one in this case. Need to account for this

[peterwoodworth]

We accept contributions! Check out our contributing guide if you're interested - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂

[VarunWachaspati]

I ran into the same issue few days ago while experimenting with CDK. Raised a pull request #21900 to fix the issue.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.