Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(elbv2): Health check interval should be longer than timeout #22200

Closed
1 of 2 tasks
riita10069 opened this issue Sep 23, 2022 · 3 comments
Closed
1 of 2 tasks

(elbv2): Health check interval should be longer than timeout #22200

riita10069 opened this issue Sep 23, 2022 · 3 comments
Assignees
@colifran
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@riita10069
Copy link
Member

riita10069 commented Sep 23, 2022 •
edited by colifran

Describe the feature

Hi Team!!
I would like to add the ALB health check validation.
What I felt needed support was the relationship between timeout and interval. The interval should be longer than the timeout.

Otherwise, timeout must be between 2 seconds and 120 seconds.
Interval must be at least 5 seconds but not more than 300 seconds.

image

Use Case

It is undesirable that the value set in CDK is not detected as an error until it is deployed, since exceptions should be found at the synth stage.
As an example, we found health checks.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.43.0

Environment details (OS name and version, etc.)

Mac OS
@riita10069 riita10069 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 23, 2022
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Sep 23, 2022
@riita10069 riita10069 mentioned this issue Sep 23, 2022
Closed
4 tasks
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 9, 2022

Sounds good. Is this purely about the health check?

@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2022
@rix0rrr rix0rrr removed their assignment Nov 9, 2022
@peterwoodworth peterwoodworth changed the title VALIDATION: Health check interval should be longer than timeout (elbv2): Health check interval should be longer than timeout Feb 14, 2023
@peterwoodworth peterwoodworth added @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 and removed package/tools Related to AWS CDK Tools or CLI labels Feb 14, 2023
@riita10069 riita10069 mentioned this issue Feb 16, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Feb 18, 2023
@riita10069
fix(ecs): validate ecs healthcheck (#24197)
89802a9 
----
#22200 

I add a feature to validate some contents for healthcheck.

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@colifran colifran self-assigned this Apr 24, 2023
@colifran
Copy link
Contributor

I reviewed #24197 and it looks like the work done there resolves this issue.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colifran colifran

Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rix0rrr @riita10069 @peterwoodworth @colifran