(integ-tests): awsApiCall() cannot be used with same service and action

[yamatatsu]

Describe the bug

Now, awsApiCall() cannot be used twice with same service and action.

Because AwsApiCall's id is made by string literal as following:

`AwsApiCall${service}${api}`

at here.

Expected Behavior

To be able to use with same service and action greater than twice.

Current Behavior

An error is occured.

Error message:

/aws-cdk/node_modules/constructs/lib/construct.js:334
            throw new Error(`There is already a Construct with name '${childName}' in ${typeName}${name.length > 0 ? ' [' + name + ']' : ''}`);
            ^

Error: There is already a Construct with name 'AwsApiCallLambdainvoke' in Stack [DeployAssert]
    at Node.addChild (/aws-cdk/node_modules/constructs/lib/construct.js:334:19)
    at new Node (/aws-cdk/node_modules/constructs/lib/construct.js:29:21)
    at new Construct (/aws-cdk/node_modules/constructs/lib/construct.js:368:21)
    at new ApiCallBase (/aws-cdk/packages/@aws-cdk/integ-tests/lib/assertions/api-call-base.js:13:9)
    at new AwsApiCall (/aws-cdk/packages/@aws-cdk/integ-tests/lib/assertions/sdk.js:17:9)

Reproduction Steps

import { App, Stack } from 'aws-cdk-lib';
import { Queue } from 'aws-cdk-lib/aws-sqs';
import { ExpectedResult, IntegTest } from '@aws-cdk/integ-tests-alpha';

const app = new App();
const stackA = new Stack(app, 'represent-aws-cdk-integ-tests-bug-stack-a');
const queueA = new Queue(stackA, 'queue-a');
const stackB = new Stack(app, 'represent-aws-cdk-integ-tests-bug-stack-b');
const queueB = new Queue(stackB, 'queue-b');

const integ = new IntegTest(app, 'Integ', { testCases: [stackA, stackB] });

for (const queue of [queueA, queueB]) {
  const response = integ.assertions.awsApiCall('SQS', 'sendMessage', {
    QueueUrl: queue.queueUrl,
    MessageBody: 'foo'
  });
  response.provider.addToRolePolicy({
    Effect: 'Allow',
    Action: ['sqs:SendMessage'],
    Resource: [queue.queueArn],
  });
  response.expect(ExpectedResult.objectLike({}));
}

app.synth();

See https://github.com/yamatatsu/represent-aws-cdk-integ-tests-bug .

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

v2.51.1

Framework Version

No response

Node.js Version

v18.12.1

OS

mac (apple silicon)

Language

Typescript

Language Version

3.9.10

Other information

No response

[pahud]

Thank you @yamatatsu !! It seems to make sense if we are allowed to pass an id parameter to it. Do you have any suggested solution for it? I am making this a P2 and your PR would be highly appreciated.

[yamatatsu]

@pahud
Sorry for the late reply.
The solution I found is useing hash with the argument parameters as here.
I'll create PR in this year!

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[misterjoshua]

Related to #22043

[misterjoshua]

@yamatatsu a change referencing this issue was merged and released. Is your issue resolved?

[colifran]

Closed by #27380

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.