Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bootstrapping.integtest.ts #23084

Merged
merged 4 commits into from
Nov 25, 2022
Merged

fix: bootstrapping.integtest.ts #23084

merged 4 commits into from
Nov 25, 2022

Conversation

Naumel
Copy link
Contributor

@Naumel Naumel commented Nov 25, 2022

Checking that the CloudFormationExecutionRole PermissionsBoundary property is set.

Skipping the partition addition to the fixture.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 25, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team November 25, 2022 12:43
@github-actions github-actions bot added the p2 label Nov 25, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 25, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@Naumel Naumel added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 25, 2022
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 25, 2022 12:45

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@Naumel Naumel requested a review from ryparker November 25, 2022 12:46
@Naumel Naumel marked this pull request as ready for review November 25, 2022 14:41
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a28ebb3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c594918 into main Nov 25, 2022
@mergify mergify bot deleted the Naumel-patch-1 branch November 25, 2022 19:50
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants