feat(events): EventBus policy

[otaviomacedo]

Allow users to set the resource policy for an EventBus.

Closes #23021.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Construct Runtime Dependencies:

• This PR adds new construct runtime dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[Naumel]

Build is failing, otherwise change looks sane, only one nitpick as part of the review.

@aws-cdk/aws-events: lib/event-bus.ts:318:3 - error TS2376: A 'super' call must be the first statement in the constructor when a class contains initialized properties, parameter properties, or private identifiers.
@aws-cdk/aws-events: 318   constructor(scope: Construct, id: string, props?: EventBusProps) {
@aws-cdk/aws-events:       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@aws-cdk/aws-events: 319     const { eventBusName, eventSourceName } = EventBus.eventBusProps(
@aws-cdk/aws-events:     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@aws-cdk/aws-events: ... 
@aws-cdk/aws-events: 339     this.eventSourceName = eventBus.eventSourceName;
@aws-cdk/aws-events:     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@aws-cdk/aws-events: 340   }
@aws-cdk/aws-events:     ~~~
@aws-cdk/aws-events: lib/event-bus.ts:374:3 - error TS2376: A 'super' call must be the first statement in the constructor when a class contains initialized properties, parameter properties, or private identifiers.
@aws-cdk/aws-events: 374   constructor(scope: Construct, id: string, attrs: EventBusAttributes) {
@aws-cdk/aws-events:       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@aws-cdk/aws-events: 375     const arnParts = Stack.of(scope).splitArn(attrs.eventBusArn, ArnFormat.SLASH_RESOURCE_NAME);
@aws-cdk/aws-events:     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@aws-cdk/aws-events: ... 
@aws-cdk/aws-events: 384     this.eventSourceName = attrs.eventSourceName;
@aws-cdk/aws-events:     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@aws-cdk/aws-events: 385   }
@aws-cdk/aws-events:     ~~~

[Naumel]

[nit] In the context of this class alone, it reads strangely to check for an autoCreatePolicy in the if clause when one is supplied, would it not be better to reference the import aspect instead?

[otaviomacedo]

Oh, you're absolutely right! There's no need for this property at all.

Fixed.

[Naumel]

Nice!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: cd1f9b5
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).