Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelines): SelfMutation CodeBuild project not accessible #24073

Merged
merged 2 commits into from Feb 9, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 8, 2023

The Pipelines-generated Synth CodeBuild project is already exposed so that users can tweak it or its permissions.

Do the same for the SelfMutation CodeBuild project, so that certain users with very specific use cases can stretch CDK Pipelines a little beyond its design goals.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The Pipelines-generated Synth CodeBuild project is already exposed so
that users can tweak it or its permissions.

Do the same for the SelfMutation CodeBuild project, so that certain
users with very specific use cases can stretch CDK Pipelines a little
beyond its design goals.
@rix0rrr rix0rrr requested a review from a team February 8, 2023 17:25
@rix0rrr rix0rrr self-assigned this Feb 8, 2023
@gitpod-io
Copy link

gitpod-io bot commented Feb 8, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team February 8, 2023 17:26
@github-actions github-actions bot added the p2 label Feb 8, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 8, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Feb 8, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 8, 2023 21:27

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a21213f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5942978 into main Feb 9, 2023
@mergify mergify bot deleted the huijbers/pipelines-expose-selfmutate branch February 9, 2023 17:06
@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants