fix(bootstrap): bootstrap doesn't work in non-aws partitions anymore (revert security hub finding fix) #25540
Conversation
|
|
github-actions
bot
added
bug
aws-cdk-automation
added
the
pr/needs-community-review
rix0rrr
changed the title
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
removed
the
pr/needs-community-review
kaizencc
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…(revert security hub finding fix) (#25540) **NOTE**: This PR bumps the version of the bootstrap stack to 18, but there is no need to update your bootstrap stacks as this PR changes no functionality. We are reverting #24588 because it includes hardcoded partitions in the bootstrap causing the `p0` in #25272. Including intrinsics `${AWS::Partition}` here is impossible. In addition, #24588 was reported to not actually fix the Security Hub finding: #19380 (comment). Although this is a revert, I am rolling forward the bootstrap version to 18. reverts #24588. fixes #25272. see #25273 & #25507. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
NOTE: This PR bumps the version of the bootstrap stack to 18, but there is no need to update your bootstrap stacks as this PR changes no functionality.
We are reverting #24588 because it includes hardcoded partitions in the bootstrap causing the
p0in #25272. Including intrinsics${AWS::Partition}here is impossible. In addition, #24588 was reported to not actually fix the Security Hub finding: #19380 (comment).Although this is a revert, I am rolling forward the bootstrap version to 18.
reverts #24588. fixes #25272. see #25273 & #25507.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license