Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(msk): kafka version 1.1.1. not longer supported #25565

Closed
daschaa opened this issue May 12, 2023 · 2 comments · Fixed by #25566
Closed

(msk): kafka version 1.1.1. not longer supported #25565

daschaa opened this issue May 12, 2023 · 2 comments · Fixed by #25566
Labels
@aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@daschaa
Copy link
Contributor

daschaa commented May 12, 2023

Describe the bug

When trying to deploy a Kafka cluster with version KafkaVersion.V1_1_1 I get the error

Resource handler returned message: "[ClientRequestToken: fab03ef7-2048-88e5-b49b-a58d0c91af5a] Unsupported KafkaVersion [1.1.1]. Valid values: [2.8.2.tiered, 2.6.2, 2.7.1, 2.8.0, 2.6.3, 2.7.2, 2.8.1, 2.5.1, 2.6.0, 2.6.1, 2.7.0, 2.3.1, 2.2.1, 2.4.1.1, 3.3.2, 3.1.1, 3.2.0, 3.3.1, 3.4.0]

Expected Behavior

The enum KafkaVersion contains only supported versions.

Current Behavior

KafkaVersion.V1_1_1 is still implemented.

Reproduction Steps

class KafkaVersionTest extends Stack {
  constructor(scope: Construct, id: string, { version }: {version: KafkaVersion}) {
    super(scope, id, { env });
    const vpc = Vpc.fromLookup(this, 'Vpc', { isDefault: true });

    new msk.Cluster(this, 'Cluster', {
      clusterName: `integ-test-v111`,
      kafkaVersion: KafkaVersion.V1_1_1,
      vpc,
      removalPolicy: RemovalPolicy.DESTROY,
    });
  }
}

Possible Solution

Remove the unsupported versions from the class. This should not break backwards compatibility because they can't be deployed anyways.

Additional Information/Context

No response

CDK CLI Version

2.79.1

Framework Version

No response

Node.js Version

18

OS

Mac

Language

Typescript

Language Version

No response

Other information

No response

@daschaa daschaa added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 12, 2023
@github-actions github-actions bot added the @aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) label May 12, 2023
@khushail khushail self-assigned this May 12, 2023
@khushail khushail added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label May 12, 2023
@khushail
Copy link
Contributor

Hi @daschaa ,Thanks for reporting this bug and coming up with the PR. Our team should be able to review it.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels May 12, 2023
@khushail khushail removed their assignment May 12, 2023
@mergify mergify bot closed this as completed in #25566 May 15, 2023
mergify bot pushed a commit that referenced this issue May 15, 2023
Closes #25565

As described in the docs, Apache Kafka 1.1.1 is no longer supported (only for existing clusters): [https://docs.aws.amazon.com/msk/latest/developerguide/supported-kafka-versions.html#1.1.1](https://docs.aws.amazon.com/msk/latest/developerguide/supported-kafka-versions.html#1.1.1)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants