Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-cdk-lib): (CustomResourceProviderRuntime not support NODEJS_18_X) #25665

Closed
2 tasks
notnonot opened this issue May 22, 2023 · 5 comments · Fixed by #25709
Closed
2 tasks

(aws-cdk-lib): (CustomResourceProviderRuntime not support NODEJS_18_X) #25665

notnonot opened this issue May 22, 2023 · 5 comments · Fixed by #25709
Labels
aws-cdk-lib Related to the aws-cdk-lib package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@notnonot
Copy link

Describe the feature

Add CustomResourceProviderRuntime support for nodejs 18

Use Case

Lambda can't use AWS javascript sdk v3 without nodejs 18 runtime support

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

v2.80.0

Environment details (OS name and version, etc.)

Amazon Linux 2023
@notnonot notnonot added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 22, 2023
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label May 22, 2023
@khushail
Copy link
Contributor

Hi @notnonot ,thanks for submitting this feature request. As seen here, it would be good to have this feature. I am marking this as P2 but community contributions are also welcome. Here is the contributing guide to getting started.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 22, 2023
@Zishanwang1992
Copy link
Contributor

I would like to work on this issue if no one is taking it yet.

@Zishanwang1992 Zishanwang1992 mentioned this issue May 24, 2023
Merged
@notnonot
Copy link
Author

Any new updates or plans?

@Zishanwang1992
Copy link
Contributor

@notnonot @khushail Here below is the pull request. Need someone to help review and approve the pull request.
#25709

@mergify mergify bot closed this as completed in #25709 May 31, 2023
mergify bot pushed a commit that referenced this issue May 31, 2023
@Zishanwang1992
feat(core): support nodejs18.x for CustomResourceProviderRuntime. (#2…
d99733f 
…5709)

Closes #25665

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aws-cdk-lib Related to the aws-cdk-lib package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): support nodejs18.x for CustomResourceProviderRuntime. Zishanwang1992/aws-cdk
3 participants
@notnonot @Zishanwang1992 @khushail