Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cdk-lib): attribute FindingsFilterListItems on AWS::Macie::FindingsFilter does not work #25778

Merged
merged 3 commits into from
May 30, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 30, 2023

The attribute was removed in a recent CFN Spec update.
We had then patched the attribute and type back in to avoid a breaking change.
Now I have confirmed with the service team that this attribute has actually never worked and the removal is indeed correct.
Update CDK to reflect the fix made in CloudFormation.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…FindingsFilter has been removed because it never worked

Update CDK to reflect this recent bug fix in CloudFormation.
@gitpod-io
Copy link

gitpod-io bot commented May 30, 2023

@github-actions github-actions bot added the p2 label May 30, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 30, 2023 09:13
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 30, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels May 30, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 30, 2023 09:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 30, 2023
@mergify
Copy link
Contributor

mergify bot commented May 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6629e1d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 98fd69a into main May 30, 2023
7 checks passed
@mergify mergify bot deleted the mrgrain/fix-remove-macie-patch branch May 30, 2023 11:42
@mergify
Copy link
Contributor

mergify bot commented May 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@macrombilux
Copy link

mrgrain/fix-remove-macie-patch

@mrgrain
Copy link
Contributor Author

mrgrain commented Jun 2, 2023

mrgrain/fix-remove-macie-patch

@macrombilux Yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants