Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda): add Runtime.RUBY_3_2 #25817

Merged
merged 2 commits into from
Jun 1, 2023
Merged

feat(lambda): add Runtime.RUBY_3_2 #25817

merged 2 commits into from
Jun 1, 2023

Conversation

MrArnoldPalmer
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer commented Jun 1, 2023 •
edited

Adds ruby 3.2 to the available Lambda Runtimes constants

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@MrArnoldPalmer @trivenay
feat(lambda): add Runtime.RUBY_3_2 (#150)
cb5ce0f 
* Added ruby3.2 to Lambda Runtime

* Added integration tests for rubny3.2

---------

Co-authored-by: Naman Trivedi <trivenay@amazon.com>
@gitpod-io
Copy link

gitpod-io bot commented Jun 1, 2023

@github-actions github-actions bot added the p2 label Jun 1, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 1, 2023 17:50
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 1, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Naumel Naumel added the pr-linter/exempt-readme The PR linter will not require README changes label Jun 1, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 1, 2023 17:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4fe630f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 33c820b into main Jun 1, 2023
7 checks passed
@mergify mergify bot deleted the feat/lambda-ruby-3_2 branch June 1, 2023 21:51
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naumel Naumel Naumel approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrArnoldPalmer @aws-cdk-automation @Naumel