Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app-staging-synthesizer): clean up staging resources on deletion #25906

Merged
merged 53 commits into from
Jun 21, 2023
Merged

feat(app-staging-synthesizer): clean up staging resources on deletion #25906

merged 53 commits into from
Jun 21, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Jun 8, 2023 •
edited

closes #25722

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 8, 2023

@github-actions github-actions bot added the p2 label Jun 8, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 8, 2023 13:12
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 8, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

rix0rrr
rix0rrr reviewed Jun 8, 2023
View reviewed changes
packages/custom-resource-bindings/scripts/build-and-minify-sources.js Outdated
recFolderStructure(path.join(fileOrDir, i));
}
} else {
if (path.extname(fileOrDir) === '.ts') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe even make this explicit with .lambda.ts ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we require the resulting file to be index.js

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. labels Jun 13, 2023
kaizencc and others added 22 commits June 19, 2023 15:37
@kaizencc
add tests for nodejs-entrypoint
1be7e80
@kaizencc
Merge branch 'conroy/crs' of https://github.com/aws/aws-cdk into conr…
8671b3e 
…oy/crs
@kaizencc
tpl
d002aa2
@kaizencc
tpl
7cd87f8
@kaizencc
jest config
bb2e809
@kaizencc
revert tpls
b2a4c73
@kaizencc
add back third party license change
caf78be
@kaizencc
Empty-Commit
0f2ab19
@kaizencc
third party licenses one more time
05297a1
@kaizencc
tpl
32e9add
@kaizencc
move custom-resource-handlers under scope
55bc3ab
@kaizencc
update integ test
14d5c86
@kaizencc
airlift files
c45a78f
@kaizencc
Merge branch 'main' into conroy/crs
e4f6d35
@kaizencc
snapshots
5752abe
@kaizencc
update integ test for appstagingsynth
79318d0
@kaizencc
Merge branch 'conroy/crs' of https://github.com/aws/aws-cdk into conr…
135a988 
…oy/crs
@kaizencc
Merge branch 'main' into conroy/crs
263fc43
@kaizencc
volatile tests
c28063c
@kaizencc
add esbuild devdep
95b881f
@kaizencc
Merge branch 'conroy/crs' of https://github.com/aws/aws-cdk into conr…
d6c1752 
…oy/crs
@kaizencc
snapshots
a203c3b
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 555afcf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3b14213 into main Jun 21, 2023
5 checks passed
@mergify mergify bot deleted the conroy/crs branch June 21, 2023 01:12
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(app-staging-synthesizer): clean up staging resources on deletion
3 participants
@kaizencc @aws-cdk-automation @rix0rrr