Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensearch: add throughput to EbsOptions #26137

Closed
2 tasks
richardwu opened this issue Jun 27, 2023 · 2 comments · Fixed by #26172
Closed
2 tasks

opensearch: add throughput to EbsOptions #26137

richardwu opened this issue Jun 27, 2023 · 2 comments · Fixed by #26172
Labels
@aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@richardwu
Copy link

Describe the feature

The interface EbsOptions for the opensearchservices CDK construct is missing a provisioned throughput option for eg gp3 instance types.

iops is there, but not throughput (which can be configured in the web console.

Use Case

To configure provisioned throughput in CDK.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.83.1

Environment details (OS name and version, etc.)

macOS

@richardwu richardwu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 27, 2023
@github-actions github-actions bot added the @aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package label Jun 27, 2023
@pahud
Copy link
Contributor

pahud commented Jun 27, 2023

Yes we can add this in the EbsOptions interface:

export interface EbsOptions {
/**
* Specifies whether Amazon EBS volumes are attached to data nodes in the
* Amazon OpenSearch Service domain.
*
* @default - true
*/
readonly enabled?: boolean;
/**
* The number of I/O operations per second (IOPS) that the volume
* supports. This property applies only to the Provisioned IOPS (SSD) EBS
* volume type.
*
* @default - iops are not set.
*/
readonly iops?: number;
/**
* The size (in GiB) of the EBS volume for each data node. The minimum and
* maximum size of an EBS volume depends on the EBS volume type and the
* instance type to which it is attached. For valid values, see
* [EBS volume size limits]
* (https://docs.aws.amazon.com/opensearch-service/latest/developerguide/limits.html#ebsresource)
* in the Amazon OpenSearch Service Developer Guide.
*
* @default 10
*/
readonly volumeSize?: number;
/**
* The EBS volume type to use with the Amazon OpenSearch Service domain, such as standard, gp2, io1.
*
* @default gp2
*/
readonly volumeType?: ec2.EbsDeviceVolumeType;
}

Making this a p2 feature request and we welcome community pull requests for this.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 27, 2023
@mergify mergify bot closed this as completed in #26172 Aug 22, 2023
mergify bot pushed a commit that referenced this issue Aug 22, 2023
The interface EbsOptions for the opensearchservices CDK construct is missing a provisioned throughput option for eg gp3 instance types.
iops is there, but not throughput

Closes #26137.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants