aws-cdk-lib: Missing tags when synthesizing after bundling code with esbuild

[Nevon]

Describe the bug

When using esbuild to bundle aws-cdk-lib, tags are no longer added to child nodes of a stack when using Tags.of(stack).add(...) since version 2.81.0 of aws-cdk-lib.

Expected Behavior

Tags.of(stack).add('TestTag', 'Value');

should apply the TestTag tag to all taggable child constructs of the stack, whether the code is being bundled or just transpiled.

Current Behavior

No tags are applied to any child constructs.

Reproduction Steps

See https://github.com/Nevon/aws-cdk-repro-26169 for a way to reproduce the issue. The repo creates an app and a stack, adds a few resources and then adds a tag to the stack, after which the template is synthesized. When running with ts-node the template has tags. When running after transpiling and bundling using esbuild, the template does not have any tags.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.80.1

Framework Version

No response

Node.js Version

v18.15.0

OS

Linux / Mac

Language

Typescript

Language Version

5.1.3

Other information

No response

[Nevon]

I think I figured out the issue, and I'm not sure if it should be considered a CDK bug or not. Bundling the code using the esbuild option --keep-names fixes the behavior. --keep-names makes it so that the bundler won't rename symbols in order to try to make the code smaller.

I believe this is the offending function, which was introduced in v2.81.0:

aws-cdk/packages/aws-cdk-lib/core/lib/tag-manager.ts

Lines 302 to 305 in 1130fab

	public static isTaggable(construct: any): construct is ITaggable {
	const tags = (construct as any).tags;
	return tags && typeof tags === 'object' && tags.constructor.name === 'TagManager';
	}

It's comparing the constructor name to a static string to determine if the construct is taggable. I would assume this won't work if the bundler has renamed the class. In my case it's renamed to _TagManager. An alternative approach might be to add a static property to the class to check against, instead of the constructor name, or possibly to compare to TagManager.name instead of a static string, but I'll leave it up to the CDK maintainers to determine if this should be considered a bug or not.

[pahud]

Thank you for your detailed report. We will discuss with the team.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[Ranjith072]

Hi,
i am migrating from cdk 2.70.0 to 2.88.0 python version and the issue i have is the static method isTaggable has stopped working, with the error message as shown below. if i use isTaggableV2 it works but removes all the tags i had before.