Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): credential plugin exceptions stop the entire CLI #26244

Merged
merged 6 commits into from
Jul 12, 2023
Merged

fix(cli): credential plugin exceptions stop the entire CLI #26244

merged 6 commits into from
Jul 12, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jul 5, 2023

Credential provider plugins may sometimes misbehave.

Catch any exceptions they may throw and continue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
fix(cli): credential plugin exceptions stop the entire CLI
03cb461 
Credential provider plugins may sometimes misbehave.

Catch any exceptions they may throw and continue.
@rix0rrr rix0rrr requested a review from a team July 5, 2023 18:42
@gitpod-io
Copy link

gitpod-io bot commented Jul 5, 2023

@github-actions github-actions bot added the p2 label Jul 5, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 5, 2023 18:43
@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed p2 labels Jul 5, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 5, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0b6ac53
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1a8f5ad into main Jul 12, 2023
7 checks passed
@mergify mergify bot deleted the huijbers/catch-credplugin-errors branch July 12, 2023 12:04
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@rix0rrr @bmoffatt
fix(cli): credential plugin exceptions stop the entire CLI (aws#26244)
fb46855 
Credential provider plugins may sometimes misbehave.

Catch any exceptions they may throw and continue.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rix0rrr @aws-cdk-automation @mrgrain